-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: karmadactl init supports deployment through configuration files #5357
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,106 @@ | ||
/* | ||
Copyright 2024 The Karmada Authors. | ||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
http://www.apache.org/licenses/LICENSE-2.0 | ||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
*/ | ||
|
||
package config | ||
|
||
import ( | ||
"fmt" | ||
"os" | ||
"sort" | ||
|
||
"k8s.io/apimachinery/pkg/runtime/schema" | ||
yamlserializer "k8s.io/apimachinery/pkg/runtime/serializer/yaml" | ||
"k8s.io/apimachinery/pkg/util/yaml" | ||
"k8s.io/klog/v2" | ||
) | ||
|
||
// LoadInitConfiguration loads the InitConfiguration from the specified file path. | ||
// It delegates the actual loading to the loadInitConfigurationFromFile function. | ||
func LoadInitConfiguration(cfgPath string) (*KarmadaInitConfig, error) { | ||
var config *KarmadaInitConfig | ||
var err error | ||
|
||
config, err = loadInitConfigurationFromFile(cfgPath) | ||
|
||
return config, err | ||
} | ||
|
||
// loadInitConfigurationFromFile reads the file at the specified path and converts it into an InitConfiguration. | ||
// It reads the file contents and then converts the bytes to an InitConfiguration. | ||
func loadInitConfigurationFromFile(cfgPath string) (*KarmadaInitConfig, error) { | ||
klog.V(1).Infof("loading configuration from %q", cfgPath) | ||
|
||
b, err := os.ReadFile(cfgPath) | ||
if err != nil { | ||
return nil, fmt.Errorf("unable to read config from %q: %v", cfgPath, err) | ||
} | ||
gvkmap, err := ParseGVKYamlMap(b) | ||
if err != nil { | ||
return nil, err | ||
} | ||
|
||
return documentMapToInitConfiguration(gvkmap) | ||
} | ||
|
||
// ParseGVKYamlMap parses a single YAML document into a map of GroupVersionKind to byte slices. | ||
// This function is a simplified version that handles only a single YAML document. | ||
func ParseGVKYamlMap(yamlBytes []byte) (map[schema.GroupVersionKind][]byte, error) { | ||
tiansuo114 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
gvkmap := make(map[schema.GroupVersionKind][]byte) | ||
|
||
gvk, err := yamlserializer.DefaultMetaFactory.Interpret(yamlBytes) | ||
if err != nil { | ||
return nil, fmt.Errorf("failed to interpret YAML document: %w", err) | ||
} | ||
if len(gvk.Group) == 0 || len(gvk.Version) == 0 || len(gvk.Kind) == 0 { | ||
return nil, fmt.Errorf("invalid configuration for GroupVersionKind %+v: kind and apiVersion is mandatory information that must be specified", gvk) | ||
} | ||
gvkmap[*gvk] = yamlBytes | ||
|
||
return gvkmap, nil | ||
} | ||
|
||
// documentMapToInitConfiguration processes a map of GroupVersionKind to byte slices to extract the InitConfiguration. | ||
// It iterates over the map, checking for the "InitConfiguration" kind, group, and version, and unmarshals its content into an InitConfiguration object. | ||
func documentMapToInitConfiguration(gvkmap map[schema.GroupVersionKind][]byte) (*KarmadaInitConfig, error) { | ||
var initcfg *KarmadaInitConfig | ||
|
||
gvks := make([]schema.GroupVersionKind, 0, len(gvkmap)) | ||
for gvk := range gvkmap { | ||
gvks = append(gvks, gvk) | ||
} | ||
sort.Slice(gvks, func(i, j int) bool { | ||
return gvks[i].String() < gvks[j].String() | ||
}) | ||
|
||
for _, gvk := range gvks { | ||
fileContent := gvkmap[gvk] | ||
if gvk.Kind == "KarmadaInitConfig" { | ||
if gvk.Group != GroupName || gvk.Version != SchemeGroupVersion.Version { | ||
return nil, fmt.Errorf("invalid Group or Version: expected group %q and version %q, but got group %q and version %q", GroupName, SchemeGroupVersion.Version, gvk.Group, gvk.Version) | ||
} | ||
initcfg = &KarmadaInitConfig{} | ||
if err := yaml.Unmarshal(fileContent, initcfg); err != nil { | ||
return nil, err | ||
} | ||
} | ||
} | ||
|
||
if initcfg == nil { | ||
return nil, fmt.Errorf("no KarmadaInitConfig kind was found in the YAML file") | ||
} | ||
|
||
return initcfg, nil | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tiansuo114 Can you help to recall why need to ignore
.git
here?PS: I'm exploring the reason why the license check becomes inactive, and seems this line breaks the functionality.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my detailed response under #5984 (comment), the idea is that files under the
.git/
directory, similar to those under.github/
,.idea/
, and other paths, should not be subject to license checks. When I ran the related check scripts locally, I encountered issues related to this, so I added path ignore rules to the script.