-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add plaintext object overrider #5329
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
e563556
to
b3e85ef
Compare
/assign |
799b786
to
0b8c695
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5329 +/- ##
==========================================
+ Coverage 29.36% 29.43% +0.07%
==========================================
Files 632 632
Lines 43862 43881 +19
==========================================
+ Hits 12878 12918 +40
+ Misses 30050 30014 -36
- Partials 934 949 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
4a89e1c
to
2ab8aed
Compare
@chaunceyjiang PTAL |
I think it's need to add a release-note for it. |
6d1af21
to
6600018
Compare
How to add a release note? |
@chaunceyjiang PTAL |
6600018
to
d11c4a4
Compare
Kindly ping @chaunceyjiang |
Hi @Patrick0308 thanks for your contribution! Can you post the results? And by the way, can you help me squash the commit? /kind feature |
GitHub can automatically squash commits. |
Thanks for pointing out the documentation reference. The karmada repository is not currently set up that way. Sometimes it is necessary to keep multiple commits. |
Signed-off-by: Patrick <[email protected]>
d11c4a4
to
ef5d10f
Compare
Hi @Patrick0308, @chaunceyjiang may be busy with kubeCon China 2024 in Hong Kong recently. |
Sure, what should I prepare for this? Maybe demonstrate a demo? |
That would be best. I hope you can also describe the background of the requirement, similar to a user story. |
Hi @Patrick0308 would you like to sign up for a community meeting topic? There is a community meeting in Chinese today. |
Ok, I requested the doc edit access. |
Close By #5591 |
What type of PR is this?
What this PR does / why we need it:
Add plaintextObjectOverrider to support modify a json or yaml field value.
For example:
The plaintextObjectOverrider to update the value of key's test field to "value1"
Which issue(s) this PR fixes:
Fixes #5330
Special notes for your reviewer:
Does this PR introduce a user-facing change?: