Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align federated helmreleases.helm.toolkit.fluxcd.io observedGeneration semantics with its native #5311

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

yike21
Copy link
Member

@yike21 yike21 commented Aug 6, 2024

What type of PR is this?
/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:
Part of #4870

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
NONE

`karmada-controller-manager`: Mark `.status.observedGeneration` of helmreleases.helm.toolkit.fluxcd.io with `.metadata.generation` only when all members' statuses are algined with its resource template generation.

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 6, 2024
@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 6, 2024
@yike21
Copy link
Member Author

yike21 commented Aug 6, 2024

Use karmadactl interpret to view test results:

## Execute the statusAggregation rule
$ karmadactl interpret -f customizations.yaml --operation aggregateStatus --desired-file testdata/observed-helmrelease.yaml  --status-file testdata/status-file.yaml 
---
# [1/1] aggregatedStatus:
apiVersion: helm.toolkit.fluxcd.io/v2beta1
kind: HelmRelease
metadata:
    annotations:
        resourcetemplate.karmada.io/generation: "1"
    generation: 1
    name: sample
    namespace: default
spec:
    chart:
        spec:
            chart: ./charts/podinfo
            interval: 1m
            sourceRef:
                kind: GitRepository
                name: podinfo
                namespace: default
            verify:
                secretRef:
                    name: fake-verify-secret
            version: '>=4.0.0 <5.0.0'
    interval: 5m
    kubeConfig:
        secretRef:
            name: fake-secret
    serviceAccountName: fake-sa
    test:
        enable: true
        ignoreFailures: true
    valuesFrom:
        - kind: ConfigMap
          name: fake-configmap
status:
    conditions:
        - lastTransitionTime: "2023-05-01T07:11:16Z"
          message: member1=Release reconciliation succeeded, member3=Release reconciliation succeeded
          reason: ReconciliationSucceeded
          status: "True"
          type: Ready
        - lastTransitionTime: "2023-05-01T07:11:16Z"
          message: member1=Helm install succeeded, member3=Helm install succeeded
          reason: InstallSucceeded
          status: "True"
          type: Released
    helmChart: test-helmrelease/test-helmrelease-sample
    lastAppliedRevision: 6.3.5
    lastAttemptedRevision: 6.3.5
    lastAttemptedValuesChecksum: da39a3ee5e6b4b0d3255bfef95601890afd80709
    lastReleaseRevision: 1
    observedGeneration: 1

## Execute the statusReflection rule
$ karmadactl interpret -f customizations.yaml --operation interpretStatus --observed-file testdata/observed-helmrelease.yaml 
---
# [1/1] status:
conditions:
    - lastTransitionTime: "2023-05-01T07:11:16Z"
      message: Release reconciliation succeeded
      reason: ReconciliationSucceeded
      status: "True"
      type: Ready
    - lastTransitionTime: "2023-05-01T07:11:16Z"
      message: Helm install succeeded
      reason: InstallSucceeded
      status: "True"
      type: Released
generation: 1
helmChart: test-helmrelease/test-helmrelease-sample
lastAppliedRevision: 6.3.5
lastAttemptedRevision: 6.3.5
lastAttemptedValuesChecksum: da39a3ee5e6b4b0d3255bfef95601890afd80709
lastReleaseRevision: 1
observedGeneration: 1
resourceTemplateGeneration: 1

There's one more task that needs to be done: writing a description of the test methodology.
I'll try to get it done this week :)

@yike21
Copy link
Member Author

yike21 commented Aug 6, 2024

/cc @chaunceyjiang @XiShanYongYe-Chang Please take a look~

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.38%. Comparing base (b4b6d69) to head (0cf72ac).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5311   +/-   ##
=======================================
  Coverage   28.38%   28.38%           
=======================================
  Files         632      632           
  Lines       43801    43801           
=======================================
  Hits        12432    12432           
  Misses      30464    30464           
  Partials      905      905           
Flag Coverage Δ
unittests 28.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@XiShanYongYe-Chang
Copy link
Member

Thanks a lot @yike21

Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yike21
/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2024
Copy link
Member

@chaunceyjiang chaunceyjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks~

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chaunceyjiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2024
@karmada-bot karmada-bot merged commit 37dfa37 into karmada-io:master Aug 8, 2024
12 checks passed
@yike21 yike21 deleted the generation-helmrelease branch August 8, 2024 11:02
@RainbowMango RainbowMango added this to the v1.11 milestone Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants