-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align federated helmreleases.helm.toolkit.fluxcd.io observedGeneration semantics with its native #5311
Conversation
…n semantics with its native Signed-off-by: yike21 <[email protected]>
Use karmadactl interpret to view test results:
There's one more task that needs to be done: writing a description of the test methodology. |
/cc @chaunceyjiang @XiShanYongYe-Chang Please take a look~ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5311 +/- ##
=======================================
Coverage 28.38% 28.38%
=======================================
Files 632 632
Lines 43801 43801
=======================================
Hits 12432 12432
Misses 30464 30464
Partials 905 905
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thanks a lot @yike21 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @yike21
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks~
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chaunceyjiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Part of #4870
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
NONE