-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize the health probe argument of karmada-controller-manager #5290
Standardize the health probe argument of karmada-controller-manager #5290
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5290 +/- ##
=======================================
Coverage 30.89% 30.89%
=======================================
Files 639 639
Lines 44343 44349 +6
=======================================
+ Hits 13699 13703 +4
- Misses 29664 29668 +4
+ Partials 980 978 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/ok-to-test |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/assign
Signed-off-by: wei-chenglai <[email protected]>
a75e068
to
f6d022f
Compare
The failing test(chart testing) is due to the
That is because the chart testing is against the So, for this PR, we can leave the chart unchanged and do it by another PR. [edit]: chart testing need to be improved and just created an issue to track this. |
Signed-off-by: RainbowMango <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just reverted changes of helm chart and we can bring it back after this.
/approve
@whitewindmills Do you want to take another look?
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
What type of PR is this?
/kind deprecation
/kind feature
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:
part of #5219
Special notes for your reviewer:
Does this PR introduce a user-facing change?: