add karmada.io/system label to created clusterrole+bindings

[grosser]

What type of PR is this?

/kind feature

What this PR does / why we need it:

similar to namespaces cluster-roles need to have an identifier so we can find them all (without having to guess based on names)
and allow-list them in our "are you allowed to create cluster-roles" auditing tooling

Does this PR introduce a user-facing change?:

- add karmada.io/system=true label to internally created karmada cluster-roles and cluster-role-bindings

[grosser]

cc @XiShanYongYe-Chang

[XiShanYongYe-Chang]

Hi @grosser, the lint is failed.

[grosser]

thx, fixed!

[XiShanYongYe-Chang]

The UT has a falling state.

[grosser]

https://github.com/karmada-io/karmada/blob/master/CONTRIBUTING.md#contributor-workflow only has make test, but I need to run a single file and ideally a single test, otherwise this takes forever :/

[grosser]

also make test does not show colors :/

then at least it prints the package name, but there should be instructions to run the package with go test

and the test prints this giant karmada font that it should not do

go test github.com/karmada-io/karmada/pkg/karmadactl/cmdinit/utils

------------------------------------------------------------------------------------------------------
 █████   ████   █████████   ███████████   ██████   ██████   █████████   ██████████     █████████
░░███   ███░   ███░░░░░███ ░░███░░░░░███ ░░██████ ██████   ███░░░░░███ ░░███░░░░███   ███░░░░░███

[grosser]

and the failed tests don't point to the line number that failed either 😞

[grosser]

fixed the tests hopefully 🤞

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 30.00000% with 14 lines in your changes missing coverage. Please review.

Project coverage is 28.24%. Comparing base (145a67e) to head (f4df03f).
Report is 2 commits behind head on master.

Files	Patch %	Lines
operator/pkg/karmadaresource/rbac/rbac.go	0.00%	8 Missing ⚠️
...controllers/unifiedauth/unified_auth_controller.go	0.00%	6 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #5281   +/-   ##
=======================================
  Coverage   28.23%   28.24%           
=======================================
  Files         632      632           
  Lines       43762    43774   +12     
=======================================
+ Hits        12357    12363    +6     
- Misses      30504    30511    +7     
+ Partials      901      900    -1     

Flag	Coverage Δ
unittests	28.24% <30.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[XiShanYongYe-Chang]

/cc @whitewindmills @liangyuanpeng @zhzhuang-zju

[XiShanYongYe-Chang]

Hi @grosser thanks for your contribution!

We now have a series of prs that add Karmada system or manage labels to resources. Can you help create an issue to organize all the prs in the series, so that we can have a general record of this and facilitate later retrieval.

Also, do we have similar resources to work with?

[grosser]

is this what you were looking for #5288 ?

"Also, do we have similar resources to work with?"
do you mean "are there more resources that needs labels" ?
I'm not sure, I did all that were getting flagged for us, there might be some more like configmap/secret that we don't have as much auditing for as for pods/clusterroles.

[XiShanYongYe-Chang]

Thanks @grosser

If more resources need to be modified, you can modify the track issue accordingly.

[XiShanYongYe-Chang]

Thanks~
/lgtm
/approve

[karmada-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• operator/OWNERS [XiShanYongYe-Chang]
• pkg/controllers/OWNERS [XiShanYongYe-Chang]
• pkg/karmadactl/cmdinit/OWNERS [XiShanYongYe-Chang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment