Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: clusterresourcebinding permanent-id label #5261

Merged

Conversation

a7i
Copy link
Contributor

@a7i a7i commented Jul 26, 2024

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

As described in linked PR, if the label is not set, it could lead to cluster resources being identified as orphaned work and deleted in member clusters. This PR attempts to prevent regressions from happening.

Which issue(s) this PR fixes:
Request in PR #5252 (comment)

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jul 26, 2024
@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 26, 2024
@a7i a7i force-pushed the e2e-clusterresourcebinding-annotation branch from e6548e8 to e63c367 Compare July 26, 2024 22:38
@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.25%. Comparing base (c38f169) to head (b1ce2f1).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5261   +/-   ##
=======================================
  Coverage   28.24%   28.25%           
=======================================
  Files         632      632           
  Lines       43747    43747           
=======================================
+ Hits        12357    12359    +2     
+ Misses      30488    30487    -1     
+ Partials      902      901    -1     
Flag Coverage Δ
unittests 28.25% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@a7i a7i force-pushed the e2e-clusterresourcebinding-annotation branch from e63c367 to b1ce2f1 Compare July 26, 2024 23:05
@XiShanYongYe-Chang
Copy link
Member

Thanks @a7i
/assign

Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks~
/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2024
@karmada-bot karmada-bot merged commit 195c371 into karmada-io:master Jul 27, 2024
12 checks passed
@RainbowMango RainbowMango added this to the v1.11 milestone Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants