-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e: clusterresourcebinding permanent-id label #5261
e2e: clusterresourcebinding permanent-id label #5261
Conversation
e6548e8
to
e63c367
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5261 +/- ##
=======================================
Coverage 28.24% 28.25%
=======================================
Files 632 632
Lines 43747 43747
=======================================
+ Hits 12357 12359 +2
+ Misses 30488 30487 -1
+ Partials 902 901 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Amir Alavi <[email protected]>
e63c367
to
b1ce2f1
Compare
Thanks @a7i |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks~
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
As described in linked PR, if the label is not set, it could lead to cluster resources being identified as orphaned work and deleted in member clusters. This PR attempts to prevent regressions from happening.
Which issue(s) this PR fixes:
Request in PR #5252 (comment)
Special notes for your reviewer:
Does this PR introduce a user-facing change?: