-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add metrics for recreate/update resource event when sync work status #5247
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5247 +/- ##
==========================================
- Coverage 28.26% 28.26% -0.01%
==========================================
Files 632 632
Lines 43732 43741 +9
==========================================
+ Hits 12360 12362 +2
- Misses 30470 30479 +9
+ Partials 902 900 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hi @chaunceyjiang @whitewindmills would you like to have a look? |
How about updating the release note like this:
|
53a5221
to
6d85a4b
Compare
Thanks~ |
Signed-off-by: chaosi-zju <[email protected]>
/retest |
hi @whitewindmills, do you have any further comments? |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Can you help add those new metrics in the website? |
What type of PR is this?
/kind feature
What this PR does / why we need it:
add metrics for recreate/update resource event when sync work status
detail backgroud:
When I create a sa and a sa type secret in control plane, yet, I only propagate the secret to member clusters, then the secret will be deleted immediately by sa-controller of the member cluster. In turn the work_status_controller will watch the deletion event and recreate the resource to cluster, this cycle goes on and never stops.
Normally, there shouldn't be a large number of recreate events, so, I want to record a metric of the recreate event which can monitor the abnormal situation.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Test report:
Does this PR introduce a user-facing change?: