-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding generic handling of priorityclass + namespace for flinkdeployment interpreter #5215
Adding generic handling of priorityclass + namespace for flinkdeployment interpreter #5215
Conversation
…ent interpreter Signed-off-by: mszacillo <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5215 +/- ##
==========================================
- Coverage 28.25% 28.24% -0.01%
==========================================
Files 632 632
Lines 43722 43723 +1
==========================================
- Hits 12354 12351 -3
- Misses 30465 30469 +4
Partials 903 903
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/assign @yike21
to take another look and get approval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yike21 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
The default interpreter for FlinkDeployment does not currently account for namespace or priorityclass. This was done because in our use-case, the priorityclass is shared amongst tenants and can be set statically. But after thinking again, it makes more sense to have this interpretation be generic.
This is a quick PR that adds that capability.
Special notes for your reviewer:
Does this PR introduce a user-facing change?: