Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding generic handling of priorityclass + namespace for flinkdeployment interpreter #5215

Merged

Conversation

mszacillo
Copy link
Contributor

What type of PR is this?
/kind feature

What this PR does / why we need it:
The default interpreter for FlinkDeployment does not currently account for namespace or priorityclass. This was done because in our use-case, the priorityclass is shared amongst tenants and can be set statically. But after thinking again, it makes more sense to have this interpretation be generic.

This is a quick PR that adds that capability.

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Added generic handling of priorityclass and namespace for default flinkdeployment interpreter

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 17, 2024
@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 17, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.24%. Comparing base (8859cb9) to head (d79c600).
Report is 12 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5215      +/-   ##
==========================================
- Coverage   28.25%   28.24%   -0.01%     
==========================================
  Files         632      632              
  Lines       43722    43723       +1     
==========================================
- Hits        12354    12351       -3     
- Misses      30465    30469       +4     
  Partials      903      903              
Flag Coverage Δ
unittests 28.24% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/assign @yike21
to take another look and get approval.

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 18, 2024
Copy link
Member

@yike21 yike21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!
/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yike21

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 18, 2024
@karmada-bot karmada-bot merged commit 32924ad into karmada-io:master Jul 18, 2024
12 checks passed
@RainbowMango RainbowMango added this to the v1.11 milestone Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants