-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose metrics port for karmadactl installation #5169
Expose metrics port for karmadactl installation #5169
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5169 +/- ##
==========================================
+ Coverage 28.23% 28.26% +0.02%
==========================================
Files 632 632
Lines 43566 43589 +23
==========================================
+ Hits 12302 12321 +19
- Misses 30366 30371 +5
+ Partials 898 897 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggest add a release-note for it,maybe:
karmadactl: exporting the metrics port for PodMonitor.
Either have a release note or not, both OK to me. |
Signed-off-by: whitewindmills <[email protected]>
e2afe37
to
6158fd8
Compare
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Thanks.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:
part of #5166
Special notes for your reviewer:
Does this PR introduce a user-facing change?: