Align federated DaemonSet's observedGeneration semantics with its native #5165
Conversation
karmada-bot
added
the
kind/feature
karmada-bot
added
the
size/M
|
@whitewindmills: GitHub didn't allow me to assign the following users: veophi. Note that only karmada-io members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5165 +/- ##
==========================================
- Coverage 28.22% 28.19% -0.03%
==========================================
Files 632 632
Lines 43548 43563 +15
==========================================
- Hits 12290 12282 -8
- Misses 30360 30381 +21
- Partials 898 900 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: whitewindmills <[email protected]>
whitewindmills
force-pushed
the
ds-generation
branch
from
78dbc04 to
82aad4e
Compare
karmada-bot
added
size/L
| oldStatus.NumberReady == newStatus.NumberReady && | ||
| oldStatus.UpdatedNumberScheduled == newStatus.UpdatedNumberScheduled && | ||
| oldStatus.NumberUnavailable == newStatus.NumberUnavailable { | ||
| if equality.Semantic.DeepEqual(oldStatus, newStatus) { |
There was a problem hiding this comment.
Other fields in the status may affect the current judgment.
There was a problem hiding this comment.
other fields should be empty.
There was a problem hiding this comment.
If other fields are added in the future, such as condition, the judgment here will be invalid.
There was a problem hiding this comment.
I don't think there will be this problem. even if a new field is added, DaemonSet of Karmada control plane will have this field at the end, and this judgment is still legal.
There was a problem hiding this comment.
Does that mean that other types of resources can be treated the same way?
There was a problem hiding this comment.
yes, but I only modify this because of a lint error: cyclomatic complexity too high 😂
|
@XiShanYongYe-Chang: GitHub didn't allow me to request PR reviews from the following users: veophi. Note that only karmada-io members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Thanks @yike21 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
approved
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
part of #4870
Special notes for your reviewer:
Does this PR introduce a user-facing change?: