Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose containing port of serving metrics #5139

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Expose containing port of serving metrics #5139

merged 1 commit into from
Jul 10, 2024

Conversation

wangxf1987
Copy link
Contributor

…posed, but other componment is not.

What type of PR is this?

This is improve for installation, the port of karmada-apiserver is exposed, but other componment is not.

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Expose the default port  for the karmada-controller-manager, scheduler and agent when creating a PodMonitor.

…posed, but other componment is not.

Signed-off-by: wangxiaofei67 <[email protected]>
@karmada-bot karmada-bot requested review from chaosi-zju and jrkeen July 4, 2024 12:16
@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 4, 2024
@wangxf1987
Copy link
Contributor Author

There is old conversation in the #4877

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.21%. Comparing base (cc7b9ac) to head (e63349d).
Report is 10 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5139      +/-   ##
==========================================
- Coverage   28.21%   28.21%   -0.01%     
==========================================
  Files         632      632              
  Lines       43571    43568       -3     
==========================================
- Hits        12293    12292       -1     
+ Misses      30382    30379       -3     
- Partials      896      897       +1     
Flag Coverage Δ
unittests 28.21% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RainbowMango
Copy link
Member

cc @chaosi-zju

Please help to check:

  • If any other component need to set container port names
  • If anywhere else, like karmadactl init, operator, local-up, need this

@chaosi-zju
Copy link
Member

If any other component need to set container port names

it seems there are also karmada-webhook and karmada-operator need to set container port names.

If anywhere else, like karmadactl init, operator, local-up, need this

I think karmadactl init, karmada-operator and local-up installation method also need this.

@chaosi-zju
Copy link
Member

If any other component need to set container port names

it seems there are also karmada-webhook and karmada-operator need to set container port names.

sorry, actually descheduler and scheduler-estimator also need to set container names.

CC @RainbowMango

@RainbowMango
Copy link
Member

@chaosi-zju Please help to open an issue to track the rest tasks, and then we can move this forward.

@chaosi-zju
Copy link
Member

Please help to open an issue to track the rest tasks, and then we can move this forward.

done, #5166

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2024
@karmada-bot karmada-bot merged commit 7982275 into karmada-io:master Jul 10, 2024
13 checks passed
@RainbowMango RainbowMango added this to the v1.11 milestone Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants