-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose containing port of serving metrics #5139
Conversation
…posed, but other componment is not. Signed-off-by: wangxiaofei67 <[email protected]>
There is old conversation in the #4877 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5139 +/- ##
==========================================
- Coverage 28.21% 28.21% -0.01%
==========================================
Files 632 632
Lines 43571 43568 -3
==========================================
- Hits 12293 12292 -1
+ Misses 30382 30379 -3
- Partials 896 897 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cc @chaosi-zju Please help to check:
|
it seems there are also
I think |
sorry, actually |
@chaosi-zju Please help to open an issue to track the rest tasks, and then we can move this forward. |
done, #5166 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…posed, but other componment is not.
What type of PR is this?
This is improve for installation, the port of karmada-apiserver is exposed, but other componment is not.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: