Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup helm chart #5113

Merged
merged 1 commit into from
Jul 2, 2024
Merged

cleanup helm chart #5113

merged 1 commit into from
Jul 2, 2024

Conversation

chaosi-zju
Copy link
Member

@chaosi-zju chaosi-zju commented Jul 1, 2024

What type of PR is this?

/kind cleanup
/kind bug

What this PR does / why we need it:

cleanup helm chart:

  • set karmada-metrics-adapter image pull policy to karmadaImagePullPolicy, in order to keep the same as other components
  • fix a occasional bug in post-install-job, detail refers to code comments

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jul 1, 2024
@karmada-bot karmada-bot requested review from calvin0327 and Poor12 July 1, 2024 07:38
@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 1, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 1, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.20%. Comparing base (9928020) to head (89d3780).
Report is 4 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5113   +/-   ##
=======================================
  Coverage   28.19%   28.20%           
=======================================
  Files         632      632           
  Lines       43571    43571           
=======================================
+ Hits        12287    12289    +2     
+ Misses      30386    30384    -2     
  Partials      898      898           
Flag Coverage Δ
unittests 28.20% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chaosi-zju
Copy link
Member Author

@calvin0327 can you please help review this?

Signed-off-by: chaosi-zju <[email protected]>
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 2, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 2, 2024
@karmada-bot karmada-bot merged commit 0fdd4d9 into karmada-io:master Jul 2, 2024
13 checks passed
@RainbowMango RainbowMango added this to the v1.11 milestone Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants