-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align federated StatefulSet's observedGeneration semantics with its native #5094
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5094 +/- ##
==========================================
- Coverage 28.22% 28.21% -0.02%
==========================================
Files 632 632
Lines 43551 43554 +3
==========================================
- Hits 12292 12287 -5
- Misses 30363 30369 +6
- Partials 896 898 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thanks for your contribution! Please push the code again to pass CI. |
/retest @yike21 |
desiredObj.status.updatedReplicas = 0 | ||
desiredObj.status.availableReplicas = 0 | ||
desiredObj.status.updatedReadyReplicas = 0 | ||
desiredObj.status.expectedUpdatedReplicas = 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This field does not appear to be available in the Advanced Statefulset status: https://github.com/openkruise/kruise/blob/8ae13b1b818f4b46f9317a0ce8c806bcfe4fdc00/apis/apps/v1beta1/statefulset_types.go#L267
local updatedReplicas = 0 | ||
local availableReplicas = 0 | ||
local updatedReadyReplicas = 0 | ||
local expectedUpdatedReplicas = 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks~fixed
…ative Signed-off-by: zhy76 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/lgtm
Thanks |
/assign @chaunceyjiang |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Align federated StatefulSet's observedGeneration semantics with its native
Which issue(s) this PR fixes:
Part of #4870
Special notes for your reviewer:
Does this PR introduce a user-facing change?: