Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align federated StatefulSet's observedGeneration semantics with its native #5094

Merged
merged 1 commit into from
Jun 29, 2024

Conversation

zhy76
Copy link
Member

@zhy76 zhy76 commented Jun 24, 2024

What type of PR is this?
/kind feature

What this PR does / why we need it:
Align federated StatefulSet's observedGeneration semantics with its native

Which issue(s) this PR fixes:
Part of #4870

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`karmada-controller-manager`: Mark `.status.observedGeneration` of StatefulSet with `.metadata.generation` only when all members' statuses are algined with its resource template generation.

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 24, 2024
@karmada-bot karmada-bot requested review from Poor12 and yike21 June 24, 2024 09:56
@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 24, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.21%. Comparing base (45d4b8e) to head (d7d28ea).
Report is 9 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5094      +/-   ##
==========================================
- Coverage   28.22%   28.21%   -0.02%     
==========================================
  Files         632      632              
  Lines       43551    43554       +3     
==========================================
- Hits        12292    12287       -5     
- Misses      30363    30369       +6     
- Partials      896      898       +2     
Flag Coverage Δ
unittests 28.21% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yike21
Copy link
Member

yike21 commented Jun 25, 2024

Thanks for your contribution!
Generally LGTM.

Please push the code again to pass CI.

@RainbowMango
Copy link
Member

/retest

@yike21
You can use the restest command now.

desiredObj.status.updatedReplicas = 0
desiredObj.status.availableReplicas = 0
desiredObj.status.updatedReadyReplicas = 0
desiredObj.status.expectedUpdatedReplicas = 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

local updatedReplicas = 0
local availableReplicas = 0
local updatedReadyReplicas = 0
local expectedUpdatedReplicas = 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks~fixed

Copy link
Member

@yike21 yike21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2024
@XiShanYongYe-Chang
Copy link
Member

Thanks
/lgtm

@RainbowMango
Copy link
Member

/assign @chaunceyjiang
for approval

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 29, 2024
@karmada-bot karmada-bot merged commit c0c5569 into karmada-io:master Jun 29, 2024
12 checks passed
@RainbowMango RainbowMango added this to the v1.11 milestone Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants