Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pp/cpp name length limit #5029

Merged
merged 1 commit into from
Aug 31, 2024
Merged

Remove pp/cpp name length limit #5029

merged 1 commit into from
Aug 31, 2024

Conversation

XiShanYongYe-Chang
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang commented Jun 7, 2024 •
edited by RainbowMango
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

In the previous release, the names of PP and CPP are not allowed to exceed 63 characters. Now, we remove this limit.

Which issue(s) this PR fixes:
Fix #4711

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`karmada-webhook`: Remove the limit of 63 name lengths with PropagationPolicy/ClusterPropagationPolicy resource.

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 7, 2024
@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 7, 2024
@XiShanYongYe-Chang XiShanYongYe-Chang mentioned this pull request Jun 7, 2024
Closed
30 tasks
@XiShanYongYe-Chang
Copy link
Member Author

Test report:
image

@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.39%. Comparing base (e7cb133) to head (911cc44).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5029      +/-   ##
==========================================
- Coverage   29.40%   29.39%   -0.01%     
==========================================
  Files         632      632              
  Lines       43835    43831       -4     
==========================================
- Hits        12890    12886       -4     
+ Misses      30004    30003       -1     
- Partials      941      942       +1
Flag Coverage Δ
unittests 29.39% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhzhuang-zju
Copy link
Contributor

If this is the last task, changing part of to fix would be better

@XiShanYongYe-Chang
Copy link
Member Author

/cc @whitewindmills @chaunceyjiang @RainbowMango

whitewindmills
whitewindmills reviewed Jun 17, 2024
View reviewed changes
Copy link
Member

@whitewindmills whitewindmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 17, 2024
@XiShanYongYe-Chang XiShanYongYe-Chang force-pushed the remove-pp-name-length-limit branch from 81471a3 to 6d51dd6 Compare July 27, 2024 03:47
@karmada-bot karmada-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 27, 2024
@XiShanYongYe-Chang XiShanYongYe-Chang force-pushed the remove-pp-name-length-limit branch from 6d51dd6 to b76506b Compare July 27, 2024 04:05
@XiShanYongYe-Chang
Copy link
Member Author

/retest

@XiShanYongYe-Chang XiShanYongYe-Chang force-pushed the remove-pp-name-length-limit branch from b76506b to 97207ee Compare July 27, 2024 09:30
@XiShanYongYe-Chang
Copy link
Member Author

/cc @chaunceyjiang

@XiShanYongYe-Chang XiShanYongYe-Chang force-pushed the remove-pp-name-length-limit branch from 97207ee to 8d25e63 Compare July 30, 2024 01:45
@XiShanYongYe-Chang XiShanYongYe-Chang force-pushed the remove-pp-name-length-limit branch from 8d25e63 to 6aefb27 Compare July 30, 2024 02:09
@XiShanYongYe-Chang
Copy link
Member Author

/cc @liangyuanpeng

@XiShanYongYe-Chang
Copy link
Member Author

/assign @RainbowMango

@XiShanYongYe-Chang XiShanYongYe-Chang force-pushed the remove-pp-name-length-limit branch from 6aefb27 to 2b71d7b Compare August 9, 2024 08:15
@XiShanYongYe-Chang
Copy link
Member Author

Hi @chaunceyjiang can you help take a review?
/assign @chaunceyjiang

@XiShanYongYe-Chang XiShanYongYe-Chang force-pushed the remove-pp-name-length-limit branch from 2b71d7b to 911cc44 Compare August 16, 2024 02:34
@XiShanYongYe-Chang
Copy link
Member Author

cc @RainbowMango
Can we bring this into this version?

RainbowMango
RainbowMango approved these changes Aug 31, 2024
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 31, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2024
@karmada-bot karmada-bot merged commit 350838d into karmada-io:master Aug 31, 2024
12 checks passed
@RainbowMango RainbowMango added this to the v1.11 milestone Aug 31, 2024
@XiShanYongYe-Chang XiShanYongYe-Chang deleted the remove-pp-name-length-limit branch September 25, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liangyuanpeng liangyuanpeng liangyuanpeng left review comments

@whitewindmills whitewindmills whitewindmills left review comments

@RainbowMango RainbowMango RainbowMango approved these changes

@Garrybest Garrybest Awaiting requested review from Garrybest

@chaunceyjiang chaunceyjiang Awaiting requested review from chaunceyjiang

Assignees

@RainbowMango RainbowMango

@chaunceyjiang chaunceyjiang

@whitewindmills whitewindmills

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.11
Development

Successfully merging this pull request may close these issues.

[Umbrella] Use permanent-id to replace namespace/name labels in the resource
8 participants
@XiShanYongYe-Chang @codecov-commenter @zhzhuang-zju @karmada-bot @RainbowMango @chaunceyjiang @liangyuanpeng @whitewindmills