Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update to go 1.22 #5015

Merged
merged 1 commit into from
Jun 11, 2024
Merged

update to go 1.22 #5015

merged 1 commit into from
Jun 11, 2024

Conversation

grosser
Copy link
Contributor

@grosser grosser commented Jun 2, 2024 •
edited by RainbowMango
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Just to keep recent

Does this PR introduce a user-facing change?:

Karmada is now built with Go 1.22.4.

@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jun 2, 2024
@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 2, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.19%. Comparing base (c181917) to head (9a3bb2b).
Report is 11 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #5015       +/-   ##
===========================================
- Coverage   53.32%   28.19%   -25.13%     
===========================================
  Files         253      631      +378     
  Lines       20560    43482    +22922     
===========================================
+ Hits        10964    12261     +1297     
- Misses       8870    30324    +21454     
- Partials      726      897      +171
Flag Coverage Δ
unittests 28.19% <ø> (-25.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

RainbowMango
RainbowMango reviewed Jun 4, 2024
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this.
We are going to bump Kubernetes v1.30 at this release(1.11), which requires Go 1.22.

But, could you please also update the Go version at README Prerequisites, as with this PR, we require go >= 1.22.3 now.

@RainbowMango
Copy link
Member

By the way, we also check the Go version at hack/util.sh, we probably don't need it anymore, since from Go1.21, people cannot build with lower Golang version than specified in go.mod.
It's up to you to clean it or not by this PR.

liangyuanpeng
liangyuanpeng reviewed Jun 5, 2024
View reviewed changes
go.mod Outdated
@@ -1,6 +1,6 @@
module github.com/karmada-io/karmada

go 1.21.10
go 1.22.3 // keep in sync with .go-version
Copy link
Contributor

@liangyuanpeng liangyuanpeng Jun 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.22.4 is live now,how about let's update version to 1.22.4, it's resolve a security issue (CVE-2024-24790 ).

REF:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@grosser
update to go 1.22
9a3bb2b 
Signed-off-by: Michael Grosser <[email protected]>
@grosser
Copy link
Contributor Author

grosser commented Jun 8, 2024

updated to 1.22.4 and made a list of places to keep in sync in go.mod
I'm not sure if removing from util.sh is safe when someone is using <1.21 so leaving that alone for now

RainbowMango
RainbowMango approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 11, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 11, 2024
@karmada-bot karmada-bot merged commit c426e97 into karmada-io:master Jun 11, 2024
12 checks passed
@RainbowMango RainbowMango added this to the v1.11 milestone Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liangyuanpeng liangyuanpeng liangyuanpeng left review comments

@RainbowMango RainbowMango RainbowMango approved these changes

@jwcesign jwcesign Awaiting requested review from jwcesign

@XiShanYongYe-Chang XiShanYongYe-Chang Awaiting requested review from XiShanYongYe-Chang

Assignees

@RainbowMango RainbowMango

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.11
Development

Successfully merging this pull request may close these issues.
5 participants
@grosser @codecov-commenter @RainbowMango @karmada-bot @liangyuanpeng