Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix depended-by label value exceed 63 characters in dependencies-distributor #4989

Merged
merged 1 commit into from
May 29, 2024

Conversation

XiShanYongYe-Chang
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #1741

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

karmada-controller-manager: fix depended-by label value exceed 63 characters in dependencies-distributor

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label May 27, 2024
@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 27, 2024
@XiShanYongYe-Chang
Copy link
Member Author

Test result:

image

@XiShanYongYe-Chang
Copy link
Member Author

@chaunceyjiang
Copy link
Member

/assign

@whitewindmills
Copy link
Member

/assign

Copy link
Member

@chaunceyjiang chaunceyjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

label value exceed 63 characters

Can you write an e2e to test this situation?

@XiShanYongYe-Chang
Copy link
Member Author

Can you write an e2e to test this situation?

Sure, Let me write the logic for E2E to guard this logic.

Let me contribute this in a separate PR, because I want to design the E2E related to #4711 together.

Copy link
Member

@whitewindmills whitewindmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label May 29, 2024
@whitewindmills
Copy link
Member

it seems that supplementing UT is enough.

@karmada-bot karmada-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 29, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 53.31%. Comparing base (c4ee8db) to head (d7419fe).

Files Patch % Lines
...ependenciesdistributor/dependencies_distributor.go 0.00% 12 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4989      +/-   ##
==========================================
- Coverage   53.32%   53.31%   -0.02%     
==========================================
  Files         253      253              
  Lines       20554    20554              
==========================================
- Hits        10961    10958       -3     
- Misses       8868     8870       +2     
- Partials      725      726       +1     
Flag Coverage Δ
unittests 53.31% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@chaunceyjiang chaunceyjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks~

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label May 29, 2024
@RainbowMango
Copy link
Member

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 29, 2024
@karmada-bot karmada-bot merged commit 6058fe1 into karmada-io:master May 29, 2024
12 checks passed
@XiShanYongYe-Chang XiShanYongYe-Chang deleted the fix-1741 branch June 7, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The label value of the dependent resoucebinding over 63 characters
6 participants