feat: remove PersistentVolumeClaim annotation volume.kubernetes.io/selected-node
#4943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karmada-bot
added
the
size/L
…/selected-node` Signed-off-by: Amir Alavi <[email protected]>
a7i
force-pushed
the
retain-pv-selected-node
branch
from
cb5edb4 to
384afd4
Compare
a7i
changed the title
PersistentVolumeClaim annotation `volume.kubernetes.io…PersistentVolumeClaim annotation volume.kubernetes.io/selected-node
a7i
changed the title
PersistentVolumeClaim annotation volume.kubernetes.io/selected-nodePersistentVolumeClaim annotation volume.kubernetes.io/selected-node
There was a problem hiding this comment.
/approve
Leave LGTM to @XiShanYongYe-Chang to take another look.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
As my colleague @jklaw90 discovered that selected-node is for the node that volume is mounted on. If this node doesn't exist, then it is never removed. See upstream issue: kubernetes/kubernetes#100485
we should also remove this field since it's irrelevant, given that node names are likely not going to be the same.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: