Bump sigs.k8s.io/controller-runtime to v0.17.5 #4921
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR updates the controller-runtime version.
Which issue(s) this PR fixes:
part of #4907
Special notes for your reviewer:
Due to these two breaking changes in the controller-runtime:
apiutil.NewDiscoveryRESTMapper
, useDynamicRESTMapper
by default for cache (⚠️ Remove apiutil.NewDiscoveryRESTMapper, use DynamicRESTMapper by default for cache kubernetes-sigs/controller-runtime#2611)TypeMeta
for unstructured (⚠️ Fakeclient: Only set TypeMeta for unstructured kubernetes-sigs/controller-runtime#2633),I replace the
NewDiscoveryRESTMapper
withNewDynamicRESTMapper
inmembercluster_client.go
, and removeTypeMeta
check in some of the tests.Does this PR introduce a user-facing change?:
NONE