-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add client-go oidc auth provider #4883
Conversation
Welcome @guozheng-shen! It looks like this is your first PR to karmada-io/karmada 🎉 |
ab96408
to
54d3c9e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @guozheng-shen thanks for your contribution.
Do all components need to be imported into this package? I understand that it is only used when karmadactl joins.
a77c621
to
6054f94
Compare
@XiShanYongYe-Chang ok, it's done, pls review again, Thanks. |
Hi @guozheng-shen can you help describe how we can use OIDC for certification with this PR? |
@XiShanYongYe-Chang Our kubeconfig uses oidc to access the k8s cluster. When I use karmadactl to join my member cluster, an error occurs causing the member cluster to fail to join (panic: No Auth provider found for the name "oidc", we need to import (_"k8s.io/client-go/plugin/pkg/client/auth/oidc") when karmadactl run. It will provide a newOIDCAuthProvider |
Signed-off-by: guozheng-shen <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4883 +/- ##
==========================================
+ Coverage 53.07% 53.13% +0.06%
==========================================
Files 251 251
Lines 20389 20417 +28
==========================================
+ Hits 10821 10849 +28
+ Misses 8855 8854 -1
- Partials 713 714 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
/lgtm
/cc @RainbowMango
/assign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
In our clusters, OIDC authentication is required for cluster operation auditing and access control. This is also a common authentication method. I believe it can be integrated into Karmada.
Which issue(s) this PR fixes:
NONE
Special notes for your reviewer:
Does this PR introduce a user-facing change?: