Deprecate name/namespace labels of work

[whitewindmills]

What type of PR is this?
/kind feature

What this PR does / why we need it:

work.karmada.io/namespace, work.karmada.io/name -> work.karmada.io/permanent-id

Which issue(s) this PR fixes:
part of #4711

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

karmada-controller-manager: deprecate name/namespace labels of work.

[whitewindmills]

Split from #4743.
/cc @RainbowMango

[whitewindmills]

@XiShanYongYe-Chang PTAL~

[XiShanYongYe-Chang]

/assign

[XiShanYongYe-Chang]

Do we also need to be clear about the labels here:

karmada/pkg/controllers/namespace/namespace_sync_controller.go

Lines 163 to 164 in 6e5a602

	util.MergeLabel(clonedNamespaced, workv1alpha1.WorkNamespaceLabel, workNamespace)
	util.MergeLabel(clonedNamespaced, workv1alpha1.WorkNameLabel, workName)

I submit a pr to fix this: #4865

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 53.07%. Comparing base (8f9a624) to head (8328054).
Report is 4 commits behind head on master.

Files	Patch %	Lines
pkg/controllers/status/work_status_controller.go	63.63%	4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4813      +/-   ##
==========================================
- Coverage   53.08%   53.07%   -0.02%     
==========================================
  Files         251      251              
  Lines       20387    20389       +2     
==========================================
- Hits        10822    10821       -1     
- Misses       8852     8855       +3     
  Partials      713      713              

Flag	Coverage Δ
unittests	53.07% <66.66%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[whitewindmills]

@RainbowMango @XiShanYongYe-Chang
can we safely remove this file? since it won't be used.

karmada/pkg/apis/work/v1alpha1/well_known_constants.go

Lines 1 to 25 in a57ca7e

	/*
	Copyright 2021 The Karmada Authors.
	Licensed under the Apache License, Version 2.0 (the "License");
	you may not use this file except in compliance with the License.
	You may obtain a copy of the License at
	http://www.apache.org/licenses/LICENSE-2.0
	Unless required by applicable law or agreed to in writing, software
	distributed under the License is distributed on an "AS IS" BASIS,
	WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
	See the License for the specific language governing permissions and
	limitations under the License.
	*/
	package v1alpha1
	const (
	// WorkNamespaceLabel is added to objects to specify associated Work's namespace.
	WorkNamespaceLabel = "work.karmada.io/namespace"
	// WorkNameLabel is added to objects to specify associated Work's name.
	WorkNameLabel = "work.karmada.io/name"
	)

[XiShanYongYe-Chang]

can we safely remove this file? since it won't be used.

The file is empty. I think we can remove it.

[whitewindmills]

Please continue to help review this PR.
/cc @RainbowMango

[RainbowMango]

OK, thanks. will do ASAP.

This PR focuses on removing labels(work.karmada.io/namespace, work.karmada.io/name) from the codebase, right?

[whitewindmills]

This PR focuses on removing labels(work.karmada.io/namespace, work.karmada.io/name) from the codebase, right?

yes

[RainbowMango]

Generally looks good to me.

[RainbowMango]

/lgtm

/assign @XiShanYongYe-Chang

[XiShanYongYe-Chang]

Thanks~
/lgtm

[RainbowMango]

/approve

[karmada-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [RainbowMango]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment