Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pprof option to metrics-adapter #4786

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Conversation

chaosi-zju
Copy link
Member

@chaosi-zju chaosi-zju commented Apr 1, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

add pprof option to metrics-adapter.

refer to Profiling Karmada.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`karmada-metrics-adapter`: Introduced the `--profiling` and `--profiling-bind-address` flags to enable and control profiling.

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 1, 2024
@karmada-bot karmada-bot requested review from jwcesign and Poor12 April 1, 2024 07:48
@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 1, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.76%. Comparing base (dca5c1a) to head (2bfaccf).
Report is 37 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4786      +/-   ##
==========================================
- Coverage   51.77%   51.76%   -0.02%     
==========================================
  Files         250      250              
  Lines       25000    24980      -20     
==========================================
- Hits        12944    12931      -13     
+ Misses      11346    11340       -6     
+ Partials      710      709       -1     
Flag Coverage Δ
unittests 51.76% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RainbowMango
Copy link
Member

/lgtm
/assign @chaunceyjiang

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2024
Copy link
Member

@chaunceyjiang chaunceyjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks~

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chaunceyjiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2024
@karmada-bot karmada-bot merged commit 74d587c into karmada-io:master Apr 2, 2024
12 checks passed
@RainbowMango
Copy link
Member

Just added a release note to the PR description.
cc @chaosi-zju

@RainbowMango
Copy link
Member

RainbowMango commented Apr 2, 2024

Why the --profiling is enabled by default? I remember it should be disabled by default.

      --profiling                                                                                                                                                                                   
                Enable profiling via web interface host:port/debug/pprof/ (default true)
      --profiling-bind-address string                                                                                                                                                               
                The TCP address for serving profiling(e.g. 127.0.0.1:6060, :6060). This is only applicable if profiling is enabled. (default ":6060")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants