labels cannot be deleted via Karmada propagation #4784
Conversation
Signed-off-by: whitewindmills <[email protected]>
karmada-bot
added
the
size/L
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4784 +/- ##
==========================================
+ Coverage 51.76% 51.77% +0.01%
==========================================
Files 250 250
Lines 24980 24980
==========================================
+ Hits 12930 12933 +3
+ Misses 11340 11338 -2
+ Partials 710 709 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -82,7 +83,6 @@ func CreateOrUpdateWork(client client.Client, workMeta metav1.ObjectMeta, resour | |||
| if util.GetLabelValue(runtimeObject.Labels, workv1alpha2.WorkPermanentIDLabel) == "" { | |||
| runtimeObject.Labels = util.DedupeAndMergeLabels(runtimeObject.Labels, map[string]string{workv1alpha2.WorkPermanentIDLabel: uuid.New().String()}) | |||
| } | |||
| util.RecordManagedLabels(runtimeObject) | |||
There was a problem hiding this comment.
Oh, great find! The workv1alpha2.ManagedLabels should be recorded on the workload rather than the work.
Can you post a screenshot of your fixed test results?
LGTM
/cc @RainbowMango @XiShanYongYe-Chang PTAL.
There was a problem hiding this comment.
Can you post a screenshot of your fixed test results?
of course.
test label: foo: bar
|
Thanks~ |
|
@whitewindmills can you help add the release-note? |
|
@XiShanYongYe-Chang done. |
|
/assign @RainbowMango |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
approved
…-#4784-upstream-release-1.9 Automated cherry pick of #4784: labels cannot be deleted via Karmada propagation
…-#4784-upstream-release-1.8 Automated cherry pick of #4784: labels cannot be deleted via Karmada propagation
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #4781
Special notes for your reviewer:
Does this PR introduce a user-facing change?: