-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecated namespace and name label for PP/CPP #4748
Deprecated namespace and name label for PP/CPP #4748
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
98e2d63
to
5132d31
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4748 +/- ##
=======================================
Coverage 51.81% 51.81%
=======================================
Files 250 250
Lines 24983 24988 +5
=======================================
+ Hits 12944 12947 +3
- Misses 11330 11331 +1
- Partials 709 710 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
e21f6bd
to
5356f24
Compare
Signed-off-by: changzhen <[email protected]>
5356f24
to
2716658
Compare
Hi @whitewindmills the CI has been passed. |
@XiShanYongYe-Chang thanks for your fix, I'm also trying to fix the CI error caused by my modifications. |
In favor of #4743, just close this PR. |
@XiShanYongYe-Chang: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Replace the use of
namespace/name
labels in the code withpermanent-id
labels for PP/CPP, including:propagationpolicy.karmada.io/namespace
,propagationpolicy.karmada.io/name
->propagationpolicy.karmada.io/permanent-id
clusterpropagationpolicy.karmada.io/name
->clusterpropagationpolicy.karmada.io/permanent-id
Which issue(s) this PR fixes:
Part of #4711
Special notes for your reviewer:
Does this PR introduce a user-facing change?: