Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated namespace and name label for PP/CPP #4748

Conversation

XiShanYongYe-Chang
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

Replace the use of namespace/name labels in the code with permanent-id labels for PP/CPP, including:

  • propagationpolicy.karmada.io/namespace, propagationpolicy.karmada.io/name -> propagationpolicy.karmada.io/permanent-id
  • clusterpropagationpolicy.karmada.io/name -> clusterpropagationpolicy.karmada.io/permanent-id

Which issue(s) this PR fixes:
Part of #4711

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

karmada-controller-manager: deprecated namespace and name label for PP/CPP

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 25, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign garrybest after the PR has been reviewed.
You can assign the PR to them by writing /assign @garrybest in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Mar 25, 2024
@XiShanYongYe-Chang XiShanYongYe-Chang force-pushed the deprecated-namespace-name-label branch 2 times, most recently from 98e2d63 to 5132d31 Compare March 25, 2024 09:55
@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 3.44828% with 168 lines in your changes are missing coverage. Please review.

Project coverage is 51.81%. Comparing base (c5c6ffa) to head (2716658).

Files Patch % Lines
pkg/detector/detector.go 0.00% 97 Missing ⚠️
pkg/detector/policy.go 0.00% 44 Missing ⚠️
pkg/detector/preemption.go 0.00% 9 Missing ⚠️
pkg/util/annotation.go 0.00% 9 Missing ⚠️
pkg/util/fedinformer/keys/keys.go 41.66% 7 Missing ⚠️
pkg/scheduler/event_handler.go 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4748   +/-   ##
=======================================
  Coverage   51.81%   51.81%           
=======================================
  Files         250      250           
  Lines       24983    24988    +5     
=======================================
+ Hits        12944    12947    +3     
- Misses      11330    11331    +1     
- Partials      709      710    +1     
Flag Coverage Δ
unittests 51.81% <3.44%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@XiShanYongYe-Chang XiShanYongYe-Chang force-pushed the deprecated-namespace-name-label branch 2 times, most recently from e21f6bd to 5356f24 Compare March 26, 2024 09:42
@XiShanYongYe-Chang XiShanYongYe-Chang force-pushed the deprecated-namespace-name-label branch from 5356f24 to 2716658 Compare March 26, 2024 09:43
@XiShanYongYe-Chang
Copy link
Member Author

Hi @whitewindmills the CI has been passed.

@whitewindmills
Copy link
Member

@XiShanYongYe-Chang thanks for your fix, I'm also trying to fix the CI error caused by my modifications.

@XiShanYongYe-Chang
Copy link
Member Author

In favor of #4743, just close this PR.
/close

@karmada-bot
Copy link
Collaborator

@XiShanYongYe-Chang: Closed this PR.

In response to this:

In favor of #4743, just close this PR.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@XiShanYongYe-Chang XiShanYongYe-Chang deleted the deprecated-namespace-name-label branch June 7, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants