operator: add extra annotations for service of karmada apiserver #4679
+28
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karmada-bot
added
the
kind/feature
karmada-bot
added
the
size/S
calvin0327
force-pushed
the
support-apiserver-annotations
branch
from
ad2a3b2 to
1246777
Compare
calvin0327
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4679 +/- ##
==========================================
- Coverage 51.41% 51.39% -0.02%
==========================================
Files 250 250
Lines 24979 24979
==========================================
- Hits 12843 12839 -4
- Misses 11431 11433 +2
- Partials 705 707 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
the below is test results: 
|
calvin0327
changed the title
karmada-bot
added
the
do-not-merge/work-in-progress
Signed-off-by: calvin <[email protected]>
calvin0327
force-pushed
the
support-apiserver-annotations
branch
from
1246777 to
739c4fa
Compare
calvin0327
changed the title
karmada-bot
removed
the
do-not-merge/work-in-progress
|
@RainbowMango @chaosi-zju PTAL, thanks |
RainbowMango
approved these changes
Mar 7, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
add extra annotations for service of karmada apiserver.
details please see below issue:
Which issue(s) this PR fixes:
Fixes #4634
Special notes for your reviewer:
Does this PR introduce a user-facing change?: