Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: clean the endpointslice if the current cluster is not in the mcs consumption clusters #4343

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

jwcesign
Copy link
Member

@jwcesign jwcesign commented Nov 30, 2023

What type of PR is this?
/kind feature

What this PR does / why we need it:
Firstly, member1 and member2 are in the consumption clusters set,
Then, the consumption clusters set changes to member1.
We should clean the endpointslice dispatched to member2 before.

Which issue(s) this PR fixes:
Fixes #none

Special notes for your reviewer:
none

Does this PR introduce a user-facing change?:


@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 30, 2023
@karmada-bot karmada-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 30, 2023
@jwcesign jwcesign force-pushed the clean-eps-when-mcs-changes branch 2 times, most recently from 3016d2b to 9e71bc2 Compare November 30, 2023 12:10
@karmada-bot karmada-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 30, 2023
@jwcesign jwcesign force-pushed the clean-eps-when-mcs-changes branch from 9e71bc2 to fa9ee42 Compare November 30, 2023 12:11
@jwcesign jwcesign force-pushed the clean-eps-when-mcs-changes branch from fa9ee42 to ffed3f3 Compare November 30, 2023 12:26
@codecov-commenter
Copy link

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (64d0873) 51.81% compared to head (ffed3f3) 51.78%.
Report is 2 commits behind head on master.

Files Patch % Lines
pkg/util/helper/mcs.go 0.00% 10 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4343      +/-   ##
==========================================
- Coverage   51.81%   51.78%   -0.03%     
==========================================
  Files         243      243              
  Lines       24102    24112      +10     
==========================================
- Hits        12488    12486       -2     
- Misses      10933    10945      +12     
  Partials      681      681              
Flag Coverage Δ
unittests 51.78% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2023
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2023
@karmada-bot karmada-bot merged commit 68d937e into karmada-io:master Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants