-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: clean the endpointslice if the current cluster is not in the mcs consumption clusters #4343
feat: clean the endpointslice if the current cluster is not in the mcs consumption clusters #4343
Conversation
3016d2b
to
9e71bc2
Compare
9e71bc2
to
fa9ee42
Compare
pkg/controllers/multiclusterservice/endpointslice_dispatch_controller.go
Outdated
Show resolved
Hide resolved
…s consumption clusters Signed-off-by: jwcesign <[email protected]>
fa9ee42
to
ffed3f3
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4343 +/- ##
==========================================
- Coverage 51.81% 51.78% -0.03%
==========================================
Files 243 243
Lines 24102 24112 +10
==========================================
- Hits 12488 12486 -2
- Misses 10933 10945 +12
Partials 681 681
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Firstly, member1 and member2 are in the consumption clusters set,
Then, the consumption clusters set changes to member1.
We should clean the endpointslice dispatched to member2 before.
Which issue(s) this PR fixes:
Fixes #none
Special notes for your reviewer:
none
Does this PR introduce a user-facing change?: