Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added MCS Kubernetes native implementation details #4194

Conversation

XiShanYongYe-Chang
Copy link
Member

What type of PR is this?

/kind design
/kind documentation

What this PR does / why we need it:

In the process of implementing the program, it was found that some points of function implementation were not described in the proposal, so here is a revision to further refine the implementation of the program, and some additions to the implementation of the key points.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/design Categorizes issue or PR as related to design. labels Oct 30, 2023
@karmada-bot karmada-bot added kind/documentation Categorizes issue or PR as related to documentation. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 30, 2023
@XiShanYongYe-Chang XiShanYongYe-Chang force-pushed the added-K8s-native-implementation-details branch from 975b7db to 26d4463 Compare November 8, 2023 03:54
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (50b0c51) 52.76% compared to head (26d4463) 52.79%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4194      +/-   ##
==========================================
+ Coverage   52.76%   52.79%   +0.02%     
==========================================
  Files         239      239              
  Lines       23584    23584              
==========================================
+ Hits        12445    12451       +6     
+ Misses      10462    10457       -5     
+ Partials      677      676       -1     
Flag Coverage Δ
unittests 52.79% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@XiShanYongYe-Chang XiShanYongYe-Chang changed the title [WIP] Added MCS Kubernetes native implementation details Added MCS Kubernetes native implementation details Nov 21, 2023
@karmada-bot karmada-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 21, 2023
@XiShanYongYe-Chang
Copy link
Member Author

#4287 is based on the current PR for iteration and applies to merge into the current PR first.
/cc @RainbowMango

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

OK. let's iterate it at #4287

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2023
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2023
@karmada-bot karmada-bot merged commit 8626902 into karmada-io:master Nov 21, 2023
jwcesign pushed a commit to jwcesign/karmada that referenced this pull request Nov 21, 2023
…native-implementation-details

Added MCS Kubernetes native implementation details
@XiShanYongYe-Chang XiShanYongYe-Chang deleted the added-K8s-native-implementation-details branch February 27, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/design Categorizes issue or PR as related to design. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants