Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.5] bump k8s.io dependencies to v0.26.4 #3930

Merged

Conversation

liangyuanpeng
Copy link
Contributor

@liangyuanpeng liangyuanpeng commented Aug 10, 2023

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Clients using client-go v0.26.0 - v0.26.3 can panic under the following conditions

  • API Server v1.27+ or v1.26 and feature gate enabled --feature-gates=AggregatedDiscoveryEndpoint=true
  • Cluster contains aggregated api server for custom metrics (e.g. Prometheus) or any aggregated api server returning malformed discovery.

Ref: kubernetes/kubernetes#119840

Related:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Bump k8s.io dependencies to v0.26.4

@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Aug 10, 2023
@karmada-bot karmada-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Aug 10, 2023
@RainbowMango RainbowMango modified the milestone: v1.7 Aug 10, 2023
go.mod Outdated Show resolved Hide resolved
@liangyuanpeng liangyuanpeng force-pushed the 1.5_bump_k8sio_0.26.4 branch from cb3390f to a5c019b Compare August 10, 2023 09:41
@karmada-bot karmada-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 10, 2023
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks
/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 10, 2023
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2023
@karmada-bot karmada-bot merged commit 6c71ea9 into karmada-io:release-1.5 Aug 10, 2023
@liangyuanpeng liangyuanpeng deleted the 1.5_bump_k8sio_0.26.4 branch August 11, 2023 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants