feat: implement preemption between propagation policies

[whitewindmills]

What type of PR is this?
/kind feature

What this PR does / why we need it:
implement preemption between propagation policies

Which issue(s) this PR fixes:
part of feature

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

[whitewindmills]

test result

1. create configmap test-cm.

apiVersion: v1
data:
  a: b
kind: ConfigMap
metadata:
  creationTimestamp: "2023-07-27T03:36:57Z"
  labels:
    propagationpolicy.karmada.io/name: test-pp
    propagationpolicy.karmada.io/namespace: default
  name: test-cm
  namespace: default
  resourceVersion: "4121865"
  uid: 962cf2d0-55f1-4ab7-9286-50499fefe3b1

2. create cpp test-cpp.

apiVersion: policy.karmada.io/v1alpha1
kind: ClusterPropagationPolicy
metadata:
  creationTimestamp: "2023-07-27T03:39:34Z"
  generation: 2
  name: test-cpp
  resourceVersion: "4116922"
  uid: fc1f2c80-8ba0-4f65-bb91-7240d26a1c5a
spec:
  conflictResolution: Abort
  placement:
    clusterTolerations:
    - effect: NoExecute
      key: cluster.karmada.io/not-ready
      operator: Exists
      tolerationSeconds: 300
    - effect: NoExecute
      key: cluster.karmada.io/unreachable
      operator: Exists
      tolerationSeconds: 300
    replicaScheduling:
      replicaSchedulingType: Duplicated
  preemption: Never
  priority: 10
  resourceSelectors:
  - apiVersion: v1
    kind: ConfigMap
    name: test-cm
    namespace: default
  schedulerName: default-scheduler

3. configmap test-cm was bound to cpp test-cpp.
   
4. create pp test-pp which priority is lower than cpp test-cpp.

apiVersion: policy.karmada.io/v1alpha1
kind: PropagationPolicy
metadata:
  creationTimestamp: "2023-07-27T03:46:48Z"
  generation: 1
  name: test-pp
  namespace: default
  resourceVersion: "4121864"
  uid: 4b8cbbe2-ba23-40f1-8a17-d23b0f29711a
spec:
  conflictResolution: Abort
  placement:
    clusterTolerations:
    - effect: NoExecute
      key: cluster.karmada.io/not-ready
      operator: Exists
      tolerationSeconds: 300
    - effect: NoExecute
      key: cluster.karmada.io/unreachable
      operator: Exists
      tolerationSeconds: 300
    replicaScheduling:
      replicaDivisionPreference: Aggregated
      replicaSchedulingType: Divided
  preemption: Always
  priority: 0
  resourceSelectors:
  - apiVersion: v1
    kind: ConfigMap
    name: test-cm
    namespace: default
  schedulerName: default-scheduler

5. pp test-pp preempts cpp test-cpp regardless of priority.
   

related logs

[whitewindmills]

/cc @RainbowMango

[codecov-commenter]

Codecov Report

Merging #3845 (1561cf9) into master (f160ea7) will decrease coverage by 0.10%.
Report is 14 commits behind head on master.
The diff coverage is 0.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #3845      +/-   ##
==========================================
- Coverage   55.20%   55.11%   -0.10%     
==========================================
  Files         227      227              
  Lines       21647    21706      +59     
==========================================
+ Hits        11950    11963      +13     
- Misses       9061     9106      +45     
- Partials      636      637       +1     

Flag	Coverage Δ
unittests	55.11% <0.00%> (-0.10%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
pkg/detector/detector.go	0.00% <0.00%> (ø)
pkg/detector/policy.go	0.00% <0.00%> (ø)
pkg/detector/preemption.go	0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

[Poor12]

/assign

[Poor12]

/lgtm

[RainbowMango]

/assign

[RainbowMango]

Can you help to run the test again?
I just tested it on my side, seems it does not work as expected, I'll run again.

[whitewindmills]

I just tested it on my side, seems it does not work as expected, I'll run again.

could you share your karmada-controller-manager logs? I only need logs of the detector.go and preemption.go, like this screenshot.

[RainbowMango]

Sorry, I forgot to set the feature gate... I usually test PR by hack/local-up-karmada.sh.

W0731 11:48:38.771315       1 preemption.go:22] Cannot handle the preemption process because feature gate "PropagationPolicyPreemption" is not enabled.

It works fine~ Thanks.

[RainbowMango]

/lgtm
/approve

[karmada-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [RainbowMango]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[whitewindmills]

thanks~