Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chart: Support custom labels variable for etcd #3138

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

my-git9
Copy link
Member

@my-git9 my-git9 commented Feb 9, 2023

What type of PR is this?
/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

chart: Support custom labels variable for etcd

@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Feb 9, 2023
@karmada-bot karmada-bot requested review from jrkeen and rv64m February 9, 2023 15:37
@karmada-bot karmada-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Feb 9, 2023
@my-git9
Copy link
Member Author

my-git9 commented Feb 9, 2023

/kind feature

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 9, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #3138 (e0f1aac) into master (57236e5) will decrease coverage by 0.01%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #3138      +/-   ##
==========================================
- Coverage   48.00%   47.99%   -0.01%     
==========================================
  Files         200      200              
  Lines       18082    18082              
==========================================
- Hits         8680     8679       -1     
- Misses       8921     8922       +1     
  Partials      481      481              
Flag Coverage Δ
unittests 47.99% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/search/proxy/store/util.go 93.83% <0.00%> (-0.48%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign @Poor12

@Poor12
Copy link
Member

Poor12 commented Feb 13, 2023

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2023
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Poor12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2023
@karmada-bot karmada-bot merged commit e39feeb into karmada-io:master Feb 13, 2023
@my-git9 my-git9 deleted the chart/etcdlabel branch July 11, 2023 14:41
@my-git9 my-git9 restored the chart/etcdlabel branch July 11, 2023 14:41
@my-git9 my-git9 deleted the chart/etcdlabel branch July 11, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants