fix typo note for pkg/sharedcli/profileflag/profileflag.go #3071
Conversation
karmada-bot
added
the
kind/cleanup
karmada-bot
added
the
size/XS
| @@ -27,7 +27,7 @@ const ( | |||
| type Options struct { | |||
| // EnableProfile is the flag about whether to enable pprof profiling. | |||
| EnableProfile bool | |||
| // ProfilePort is the TCP address for pprof profiling. | |||
| // ProfilingBindAddress is the TCP address for pprof profiling. | |||
There was a problem hiding this comment.
The default is ":6060", which means it can accept requests from any source address(I tried), so I think we need the change the flag's default value from:
fs.StringVar(&o.ProfilingBindAddress, "profiling-bind-address", ":6060", "The TCP address for serving profiling(e.g. 127.0.0.1:6060, :6060). This is only applicable if profiling is enabled.")to:
fs.StringVar(&o.ProfilingBindAddress, "profiling-bind-address", "127.0.0.1:6060", "The TCP address for serving profiling(e.g. 127.0.0.1:6060, :6060). This is only applicable if profiling is enabled.")
There was a problem hiding this comment.
This may introduce a user-facing change, I suggest updating the relevant comments. Hi @yanggangtony, can you help update it?
There was a problem hiding this comment.
// ProfilingBindAddress is the TCP address for pprof profiling.
// Defaults to :6060 if unspecified.
There was a problem hiding this comment.
yes, thanks for review..
rebased it..
Signed-off-by: yanggang <[email protected]>
yanggangtony
force-pushed
the
fix-typo
branch
from
7fe526a to
38a63a8
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
approved
Signed-off-by: yanggang [email protected]
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
fix typo note for pkg/sharedcli/profileflag/profileflag.go