generate PolicyRules from given subjects for impersonation deduplicate

[yanfeng1992]

Signed-off-by: huangyanfeng [email protected]

What type of PR is this?

/kind bug

What this PR does / why we need it:

unified-auth-controller generates PolicyRules from given subjects for impersonation need deduplicate by name

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`karmada-controller-manager`: generate PolicyRules from given subjects for impersonation deduplicate

[XiShanYongYe-Chang]

Hi @yanfeng1992, I see you close the previous one, Is there any problem with it?

Besides, you can sign off refer to https://github.com/karmada-io/karmada/pull/2911/checks?check_run_id=9934498163

[XiShanYongYe-Chang]

@yanfeng1992 nice finding, thanks for your fix~
Can you help add some ut cases to cover this case?

/assign

[yanfeng1992]

@yanfeng1992 nice finding, thanks for your fix~ Can you help add some ut cases to cover this case?

/assign

I added a ut case for this fix
9cdb9de

[XiShanYongYe-Chang]

I added a ut case for this fix

Thanks~

[XiShanYongYe-Chang]

LGTM

Hi @yanfeng1992, can you help squash the commits into one? And help update the release note, just like:

`karmada-controller-manager`: generate PolicyRules from given subjects for impersonation deduplicate

/assign @RainbowMango

[yanfeng1992]

LGTM

Hi @yanfeng1992, can you help squash the commits into one? And help update the release note, just like:

`karmada-controller-manager`: generate PolicyRules from given subjects for impersonation deduplicate

/assign @RainbowMango

@XiShanYongYe-Chang I already squash the commits into one and update the release note. Are there any other questions that I need to deal with?

[RainbowMango]

Are there any other questions that I need to deal with?

Just a reminder, you might need to add your email to GitHub Emails, otherwise, GitHub can't recognize you and can't count your contributions.

[XiShanYongYe-Chang]

@XiShanYongYe-Chang I already squash the commits into one and update the release note. Are there any other questions that I need to deal with?

There's no other questions. Thanks for your contribution!
/lgtm

[RainbowMango]

/approve

Thanks.

@XiShanYongYe-Chang
I think this is more like a cleanup, should we cherry-pick?

[karmada-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [RainbowMango]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[XiShanYongYe-Chang]

I think this is more like a cleanup, should we cherry-pick?

Yes, this pr cleaned up the redundant item in the rules, and I think we do not need to cherry-pick it.

Hi @yanfeng1992, I update the related labels.
/kind cleanup
/remove-kind bug