Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

karmadactl support delete command #2019

Closed
wants to merge 1 commit into from

Conversation

chaunceyjiang
Copy link
Member

What type of PR is this?
/kind feature

What this PR does / why we need it:

Similar to kubectl delete, it will further delete the PropagationPolicy or ClusterPropagationPolicy associated with the resource

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

karmadactl support delete command

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 17, 2022
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign rainbowmango after the PR has been reviewed.
You can assign the PR to them by writing /assign @rainbowmango in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 17, 2022
@chaunceyjiang chaunceyjiang force-pushed the delete branch 7 times, most recently from fcd7bb7 to ca5772f Compare June 17, 2022 07:26
@chaunceyjiang
Copy link
Member Author

image

@chaunceyjiang
Copy link
Member Author

image

@RainbowMango
Copy link
Member

Similar to kubectl delete, it will further delete the PropagationPolicy or ClusterPropagationPolicy associated with the resource

Could you please give more details about the use case?

@RainbowMango
Copy link
Member

/close

The delete command has been provided by #5431. We can continue based on that if there are any further use cases not satisfied.

@karmada-bot
Copy link
Collaborator

@RainbowMango: Closed this PR.

In response to this:

/close

The delete command has been provided by #5431. We can continue based on that if there are any further use cases not satisfied.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants