proposal: pause ensure work object #1859
Conversation
karmada-bot
added
kind/design
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
size/L
CharlesQQ
changed the title
|
This week will be pretty rough for me as we are planning to cut the new release, I'm not sure I can take a look at this approach. But I've added this to the release-1.3 backlog. |
CharlesQQ
force-pushed
the
karmada-paused
branch
from
c517562 to
e94f4f2
Compare
|
|
||
| ## Summary | ||
|
|
||
| When the resource (as known as `resource template`) paused field(such as label `work.karmada.io/paused`) is true, we hope that the latest change, whether it is workload or PP or OP, will not be updated to the work object until it becomes false |
There was a problem hiding this comment.
The summary part should describe what the proposal is. e.g. Do you propose a work.karmada.io/paused label?
| ## Motivation | ||
| Users might add/replace/delete overriders for OP dynamically, and add/remove targetCluster in PP dynamically; | ||
| These operations should be transactional, before all modifications are done, policy should not take effect |
There was a problem hiding this comment.
The motivation part focuses on the reason why raise the proposal and why people need it.
Signed-off-by: charlesQQ <[email protected]>
CharlesQQ
force-pushed
the
karmada-paused
branch
from
e94f4f2 to
4eb59f2
Compare
|
I'm going to revisit this proposal. |
|
I'm trying to figure out which PR/Issue should be included in the coming v1.7 release which is planned at the end of this month. |
|
#5217 fix this pr. |
|
/close |
|
@CharlesQQ: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: charlesQQ [email protected]
What type of PR is this?
/kind design
/kind documentation
What this PR does / why we need it:
pause ensure work object
Which issue(s) this PR fixes:
Part of #1567
Special notes for your reviewer:
Does this PR introduce a user-facing change?: