Merge pull request #3009 from chaunceyjiang/statefulset

built-in interpreter support statefulset
karmada-io · Jan 3, 2023 · 9118be9 · 9118be9
2 parents 06fa41c + 58408c7
commit 9118be9
Show file tree

Hide file tree

Showing 3 changed files with 99 additions and 0 deletions.
diff --git a/pkg/resourceinterpreter/defaultinterpreter/replica.go b/pkg/resourceinterpreter/defaultinterpreter/replica.go
@@ -18,6 +18,7 @@ type replicaInterpreter func(object *unstructured.Unstructured) (int32, *workv1a
 func getAllDefaultReplicaInterpreter() map[schema.GroupVersionKind]replicaInterpreter {
 	s := make(map[schema.GroupVersionKind]replicaInterpreter)
 	s[appsv1.SchemeGroupVersion.WithKind(util.DeploymentKind)] = deployReplica
+	s[appsv1.SchemeGroupVersion.WithKind(util.StatefulSetKind)] = statefulSetReplica
 	s[batchv1.SchemeGroupVersion.WithKind(util.JobKind)] = jobReplica
 	return s
 }
@@ -38,6 +39,22 @@ func deployReplica(object *unstructured.Unstructured) (int32, *workv1alpha2.Repl
 	return replica, requirement, nil
 }
 
+func statefulSetReplica(object *unstructured.Unstructured) (int32, *workv1alpha2.ReplicaRequirements, error) {
+	sts := &appsv1.StatefulSet{}
+	if err := helper.ConvertToTypedObject(object, sts); err != nil {
+		klog.Errorf("Failed to convert object(%s), err", object.GroupVersionKind().String(), err)
+		return 0, nil, err
+	}
+
+	var replica int32
+	if sts.Spec.Replicas != nil {
+		replica = *sts.Spec.Replicas
+	}
+	requirement := helper.GenerateReplicaRequirements(&sts.Spec.Template)
+
+	return replica, requirement, nil
+}
+
 func jobReplica(object *unstructured.Unstructured) (int32, *workv1alpha2.ReplicaRequirements, error) {
 	job := &batchv1.Job{}
 	err := helper.ConvertToTypedObject(object, job)

diff --git a/pkg/resourceinterpreter/defaultinterpreter/revisereplica.go b/pkg/resourceinterpreter/defaultinterpreter/revisereplica.go
@@ -15,6 +15,7 @@ type reviseReplicaInterpreter func(object *unstructured.Unstructured, replica in
 func getAllDefaultReviseReplicaInterpreter() map[schema.GroupVersionKind]reviseReplicaInterpreter {
 	s := make(map[schema.GroupVersionKind]reviseReplicaInterpreter)
 	s[appsv1.SchemeGroupVersion.WithKind(util.DeploymentKind)] = reviseDeploymentReplica
+	s[appsv1.SchemeGroupVersion.WithKind(util.StatefulSetKind)] = reviseStatefulSetReplica
 	s[batchv1.SchemeGroupVersion.WithKind(util.JobKind)] = reviseJobReplica
 	return s
 }
@@ -26,6 +27,13 @@ func reviseDeploymentReplica(object *unstructured.Unstructured, replica int64) (
 	return object, nil
 }
 
+func reviseStatefulSetReplica(object *unstructured.Unstructured, replica int64) (*unstructured.Unstructured, error) {
+	if err := helper.ApplyReplica(object, replica, util.ReplicasField); err != nil {
+		return nil, err
+	}
+	return object, nil
+}
+
 func reviseJobReplica(object *unstructured.Unstructured, replica int64) (*unstructured.Unstructured, error) {
 	if err := helper.ApplyReplica(object, replica, util.ParallelismField); err != nil {
 		return nil, err

diff --git a/pkg/resourceinterpreter/defaultinterpreter/revisereplica_test.go b/pkg/resourceinterpreter/defaultinterpreter/revisereplica_test.go
@@ -158,3 +158,77 @@ func TestReviseJobReplica(t *testing.T) {
 		})
 	}
 }
+
+func TestReviseStatefulSetReplica(t *testing.T) {
+	tests := []struct {
+		name        string
+		object      *unstructured.Unstructured
+		replica     int64
+		expected    *unstructured.Unstructured
+		expectError bool
+	}{
+		{
+			name: "StatefulSet .spec.replicas accessor error, expected int64",
+			object: &unstructured.Unstructured{
+				Object: map[string]interface{}{
+					"apiVersion": "apps/v1",
+					"kind":       "StatefulSet",
+					"metadata": map[string]interface{}{
+						"name": "fake-statefulset",
+					},
+					"spec": map[string]interface{}{
+						"replicas": 1,
+					},
+				},
+			},
+			replica:     3,
+			expectError: true,
+		},
+		{
+			name: "revise statefulset replica",
+			object: &unstructured.Unstructured{
+				Object: map[string]interface{}{
+					"apiVersion": "apps/v1",
+					"kind":       "StatefulSet",
+					"metadata": map[string]interface{}{
+						"name": "fake-statefulset",
+					},
+					"spec": map[string]interface{}{
+						"replicas": int64(1),
+					},
+				},
+			},
+			replica: 3,
+			expected: &unstructured.Unstructured{
+				Object: map[string]interface{}{
+					"apiVersion": "apps/v1",
+					"kind":       "StatefulSet",
+					"metadata": map[string]interface{}{
+						"name": "fake-statefulset",
+					},
+					"spec": map[string]interface{}{
+						"replicas": int64(3),
+					},
+				},
+			},
+			expectError: false,
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			res, err := reviseStatefulSetReplica(tt.object, tt.replica)
+			if err == nil && tt.expectError == true {
+				t.Fatal("expect an error but got none")
+			}
+			if err != nil && tt.expectError != true {
+				t.Fatalf("expect no error but got: %v", err)
+			}
+			if err == nil && tt.expectError == false {
+				if !reflect.DeepEqual(res, tt.expected) {
+					t.Errorf("reviseStatefulSetReplica() = %v, want %v", res, tt.expected)
+				}
+			}
+		})
+	}
+}