feat: Added ability to set custom preferences in firefox #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return PREFS; | ||
| } | ||
| for (var key in prefs) { | ||
| PREFS += 'user_pref("' + key + '", ' + JSON.stringify(prefs[key]) + ');\n'; |
There was a problem hiding this comment.
This is mutating the global constant, so it will affect other FF launchers.
Change it to use a local variable instead.
|
This is great @axemclion ! Can you please make the one change I mentioned in the comment and please re-base it on the top of the latest master, so that I can merge it in. Thanks a bunch. |
|
Fixed the comment. Added a results object. |
|
@axemclion Thanks! Can you also rebase it on the latest master, so that I can easily merge it in? |
|
Rebased on the latest master. |
vojtajina
added a commit
that referenced
this pull request
Nov 27, 2013
feat: Added ability to set custom preferences in firefox
|
Thanks @axemclion ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability for firefox to take in custom preferences.
I am working on https://github.com/axemclion/karma-telemetry and I needed to pass in
dom.send_after_paint_to_contentfor measuring first paint time anddom.disable_open_during_loadto enable the tests to open in a new window. For now, I had to copy the code to create a new launcher, but it would be awesome if I could simply pass these preferences in to firefox.Tried to model this after the karma-chrome-launcher _getOptions function.
Tested this on Windows with the following cases