Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support semantic-release. #408

Closed
johnjbarton opened this issue Mar 23, 2020 · 5 comments
Closed

Support semantic-release. #408

johnjbarton opened this issue Mar 23, 2020 · 5 comments
Assignees
Labels

Comments

@johnjbarton
Copy link
Contributor

The karma-jasmine and karma-sauce-launcher projects have set up semantic-release, allowing reviewed commits to trigger npm releases with out waiting.

The steps are covered by commits on those projects. Roughly we need commitlint, a semantic-release dependency, a release-config, and some triggers in the travis.yml file.

@johnjbarton
Copy link
Contributor Author

@anthony-redFox is this something you might consider?

@anthony-redFox
Copy link
Collaborator

Agree, prepare new major release after update Istanbul major version libs and drop node 8 node as general karma did.

@anthony-redFox anthony-redFox self-assigned this Apr 3, 2020
anthony-redFox added a commit to anthony-redFox/karma-coverage that referenced this issue Apr 12, 2020
@karmarunnerbot
Copy link
Member

🎉 This issue has been resolved in version 2.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@johnjbarton
Copy link
Contributor Author

heh, I'm trying to figure out how this worked.

The .travis.yml just says semantic-release
https://github.com/karma-runner/karma-coverage/blob/master/.travis.yml#L15
rather than npm run semantic-release which would run the npm script in the package.json.

I gather that with language: node_js any module becomes a command?

@anthony-redFox
Copy link
Collaborator

yes, semantic-release get from folder node_modules/bin but npm run semantic-release execute semantic-release script from package.json.

language: node_js yes any module could be execute through a command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants