fix: correct Chrome path on Windows #3
Conversation
Checks for Chrome in the default location on windows taking into account 32 and 64 bit machines. Falls back to the version in the user's profile. Closes karma-runner#2
| }, | ||
| ENV_CMD: 'CHROME_CANARY_BIN' | ||
| }; | ||
|
|
||
| ChromeCanaryBrowser.$inject = ['baseBrowserDecorator', 'args']; | ||
|
|
||
| function windowsChromePath(chromeExe) { |
There was a problem hiding this comment.
Make it so that this is only executed if you are on windows.
Now, there are two fs.existsSync even if you are on Mac/Linux.
|
Also, can you please change the commit msg to just |
| if(os.platform()!=='win32') | ||
| return ''; | ||
|
|
||
| var globalInstall = os.arch()==='x64' ? process.env['ProgramFiles(x86)'] : process.env.ProgramFiles; |
There was a problem hiding this comment.
This is wrong... You load 32-bit Chrome on a 64-bit OS nad vice-versa. But even if you swapped it, it would still be wrong as Chrome is currently 32-bit even on 64-bit Windows. My approach is more future-proof: #6.
cc @vojtajina
There was a problem hiding this comment.
I think you might be misreading this. This code loads Chrome from the correct location depending on the bitness of the OS. Since there isn't a 64bit version of Chrome (and there may never be) I'm not too worried about not handling that scenario. We're using this code on several machines without issue.
There was a problem hiding this comment.
@JoeDoyle23 Ahh, you're right, I've read it wrong. I still think it's better to be future-proof, especially that it doesn't have a lot of overhead but I'm sorry for incorrectly claiming your solution is wrong.
There was a problem hiding this comment.
@JoeDoyle23 Surely some day there will be a 64-bit Chrome version, the only question is when.
|
Was there something else that you wanted me to change before accepting this? |
|
@JoeDoyle23 Thanks a bunch! I corrected some styling issues and squashed both commits. It's merged as 9ebd997. |
Checks for Chrome in the default location on windows taking into account
32 and 64 bit machines. Falls back to the version in the user's
profile.
Closes #2