Tests: use the tmp_path fixture instead of tmpdir #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmpdir uses a py.path object which will be removed at some point and is no longer actively maintained.
This simplifies and clarifies some of the path logic here.
This is easier to read at least for me.
There should now be no more calls to tmpdir :)
This ensures we do not accidentally use the tmpdir fixture instead of tmp_path in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we can infer from pytest-dev/pytest#7259 or https://github.com/pytest-dev/pytest/projects/4 the long-term plan for pytest is to replace any use of
py.pathwith the now standard-library modulepathlib. This removes any uses of thetmpdirfixture and replaces it with the corresponding calls usingtmp_pathto avoid any surprises in the future.