Infinispan Service Binding

[karesti]

No description provided.

[ryanemerson]

How about just auth and the value specified in this file could then be used to determine the auth mechanism to use in the future? If the value is false, then we set use-auth=false.

[karesti]

the evolution should go into the extension configuration too so both are equivalent. something to think about

[ryanemerson]

The intent of ServiceBinding is not to provide a 1-1 mapping between files and the existing properties so I don't this needs to be the same tbh. A ServiceBinding secret containing the file mappings can either be explicitly created by a user, or more likely, will be provisioned by a ServiceBinding provider (Infinispan operator). So only providing mappings for a small number of bindings is fine as long as the server connection can be established.

[ryanemerson]

I think we can just use the uri binding key now and use it's value to set the server-list property. The HotRodURI class can be used to parse the string and extract the addresses of the server.

Of course we can sitll add the serverlist binding, but uri is one of the well known keys proposed in the spec. It also means it's one less thing to deprecate/communicate when deprecating server-list in favour of uri in the application.properties.

The HotRodURI class also extracts the user/password combo, so we can set those properties from the uri binding if present.

[karesti]

I will use url and pass this PR after the deprecation, but I did it before so that's why I used serverList
In any case, my issue is I don't know how to validate this

[ryanemerson]

You can test by setting the quarkus.kubernetes-service-binding.root=/tmp property, you then need to create a file structure containing the servicebinding files, e.g:

/tmp/infinispan
├── username
├── password
└── type

Where each file contains the value associated with the filename.

If the ServiceBinding converter is working as expected, then the Infinispan client's properties should be configured with the values in those files.

[karesti]

I did that, but in which environment did you do that ?

[karesti]

locally it does not work and I asked someone in the Quarkus team that worked on the Kafka one and he has told me I need to do it in kube deployment. which is totally fine, I just need to know if you could test it somewhere else or with kind/minikube + operator locally or how. thanks a lot Ryan! :))) before this PR in any case first we need to deprecate serverList

[ryanemerson]

I did that, but in which environment did you do that ?

Just on my local dev machine.

Looking at the PR, I think I know why it didn't work.

You need to define the io.quarkus.kubernetes.service.binding.runtime.ServiceBindingConverter implementation as a Service in src/resources/META-INF/services/io.quarkus.kubernetes.service.binding.runtime.ServiceBindingConverter

https://github.com/gingersnap-project/db-syncer/blob/ae9ba3643b59d2dab87767983cad83d5fd290f96/src/main/resources/META-INF/services/io.quarkus.kubernetes.service.binding.runtime.ServiceBindingConverter#L3-L2