Fixing issue #1451

[joelpramos]

Description

Thanks for contributing this Pull Request. Make sure that you submit this Pull Request against the develop branch of this repository, add a brief description, and tag the relevant issue(s) and PR(s) below.

• Relevant Issues : Issue with #notnull passing when it should fail #1451
• Relevant PRs : (optional)
• Type of change :
  • New feature
  • Bug fix for existing feature
  • Code quality improvement
  • Addition or Improvement of tests
  • Addition or Improvement of documentation

[joelpramos]

Updated upload.feature due to failing unit test.

Some food for thought is that HTTP headers are not case sensitive although trying to come up with special handling just for that might be too painful and might as well leave as is - it's a testing framework so results should be repetitive anyways.

[joelpramos]

The same scenario gave me a different response the second time around? I'm logging off but maybe can check it out in the morning.

[ptrthomas]

the build failed and what's weird is the error message is kind of lacking, maybe this is the header code path not good enough, do investigate if you can

[joelpramos]

the build failed and what's weird is the error message is kind of lacking, maybe this is the header code path not good enough, do investigate if you can

yeah I'm looking at it and it seems like couple things - the headers are not consistent upper case or lower case even in my local in IntelliJ runner (like click the button) vs. running with Maven and then here with the CICD pipeline. I think might need to make a check case insensitive (like match Content-Type or match content-type #notnull)

Also getting this sometimes so I assume it's my laptop that's super slow (not typically a coder here..). Are you cool if I increase the timeout for the testing? I assume that's somewhere in a karate-config.js

[ptrthomas]

Also getting this sometimes so I assume it's my laptop that's super slow (not typically a coder here..). Are you cool if I increase the timeout for the testing? I assume that's somewhere in a karate-config.js

yes go ahead

[joelpramos]

Also getting this sometimes so I assume it's my laptop that's super slow (not typically a coder here..). Are you cool if I increase the timeout for the testing? I assume that's somewhere in a karate-config.js

yes go ahead

@ptrthomas I noticed the CI/CD build failed after you merged to develop but it was timeout as well. I ended up not pushing the change and keeping it in my local FYI.

2021-01-28T12:50:47.1608727Z org.graalvm.polyglot.PolyglotException: http call failed after 10 milliseconds for url: https://127.0.0.1:41913/headers
2021-01-28T12:50:47.1610980Z classpath:demo/headers/common-noheaders.feature:8
2021-01-28T12:50:47.1613639Z - com.intuit.karate.core.FeatureResult.getErrorMessagesCombined(FeatureResult.java:215)
2021-01-28T12:50:47.1617580Z - com.intuit.karate.core.ScenarioEngine.callFeature(ScenarioEngine.java:1938)
2021-01-28T12:50:47.1620243Z - com.intuit.karate.core.ScenarioEngine.call(ScenarioEngine.java:1854)
2021-01-28T12:50:47.1622871Z - com.intuit.karate.core.ScenarioBridge.callSingle(ScenarioBridge.java:209)
2021-01-28T12:50:47.1624045Z - <js>.fn(Unnamed:21)
2021-01-28T12:50:47.1624297Z 

[ptrthomas]

@joelpramos argh what do you suggest, do I revert this ?

[joelpramos]

Don't think so, I think we should just increase the timeout, the failure doesn't seem to be related to the actual code fix. Originally it was breaking because of some different behavior in the web container so I just forced the headers to be lower case in this method: karate-demo/src/main/java/com/intuit/karate/demo/controller/SearchController.java

It just leaves me wonder whether my fix here is poor and it'll always hit the if condition whenever we're doing a match against something that is not present - however I can't think of a way to reduce the number of iterations for that piece of code. It'll keep it in the back of my mind to get back to it later tonight.

} else if (!optional && actual.isNotPresent()) {
    // if the element is not present the expected result can only be
    // the notpresent keyword, ignored or an optional comparison
    return expected.isNotPresent() || "#ignore".contentEquals(expected.getAsString());
}