Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the "existing item" to a new conflict or it is missing from the error output #29

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

Vampire
Copy link
Contributor

@Vampire Vampire commented Sep 18, 2024

No description provided.

@sgrishchenko
Copy link
Contributor

These changes look reasonable, can you provide some sample code to test it in comments? I know it would be better to provide test, but the current test system works badly with negative checks 🙂 I can create an issue to create some unit test and provide checks for negative scenarios.

@Vampire
Copy link
Contributor Author

Vampire commented Sep 22, 2024

Which comments do you mean?
Here?
Just provoke any conflict.
For example two classes named Foo but in different modules.

@Vampire Vampire force-pushed the fix-conflict-output branch from 2e892a7 to 13b5f00 Compare September 22, 2024 22:51
@Vampire Vampire force-pushed the fix-conflict-output branch from 13b5f00 to 05ec8aa Compare September 23, 2024 19:20
@sgrishchenko
Copy link
Contributor

An interesting thing is that I tried to do what you said and I received this:

external class Foo {

}

external class Foo {

}

But I wrote the code, yea you are right, there is a bug there.

@sgrishchenko sgrishchenko merged commit 065cea6 into karakum-team:master Sep 23, 2024
3 checks passed
@Vampire Vampire deleted the fix-conflict-output branch September 23, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants