Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dependencies): git dependencies allow submodules #987

Merged
merged 9 commits into from
Jun 1, 2023

Conversation

MatteoVoges
Copy link
Contributor

@MatteoVoges MatteoVoges commented Apr 6, 2023

Fixes #914

Proposed Changes

  • Kapitan dependencies with type: git allow checkout with submodules now.
  • e.g.
  • ---
    parameters: 
      kapitan:
        dependencies:
           - type: git
             source: https://github.com/kapicorp/kapitan.git
             submodules: true 
             output_path: output/directory
    fetches kapicorp/kapitan with its submodule kapicorp/reclass

To Do

  • Add documentation
  • Add a test example

Contributed by

@MatteoVoges MatteoVoges added enhancement enhancement to an existing feature feature labels Apr 20, 2023
@MatteoVoges
Copy link
Contributor Author

I added tests and documentation. I thought about enabling the flag by default, because it would make sense to initialize the submodules of a repository. What do you think? @ademariag @ramaro @uberspot @gburiola

Ready for review 🚀

@MatteoVoges MatteoVoges added the 🚀 ready to merge label May 3, 2023
@ramaro
Copy link
Member

ramaro commented May 19, 2023

@MatteoVoges as discussed, let's have submodules enabled by default and allow disabling if necessary

@MatteoVoges
Copy link
Contributor Author

Done.

@ramaro ramaro merged commit 1a9950d into kapicorp:master Jun 1, 2023
@MatteoVoges MatteoVoges deleted the support-submodules-dependencies branch June 1, 2023 08:02
@MatteoVoges MatteoVoges mentioned this pull request Feb 7, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement enhancement to an existing feature feature 🚀 ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Git dependency and git modules
2 participants