more accurate handle for .zip kapitan-dependency #912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @metacoma ! We will review it. Feel free to join out #kapitan on kubernetes.slack if you want to chat. get invited |
ademariag
requested changes
Dec 9, 2022
metacoma
added a commit
to metacoma/mindwm
that referenced
this pull request
Dec 9, 2022
ramaro
reviewed
Dec 9, 2022
|
just friendly ping |
metacoma
added a commit
to metacoma/mindwm
that referenced
this pull request
Dec 21, 2022
|
Hello @metacoma, we'll be merging it soon, thank you for your help with this |
ramaro
approved these changes
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have the following dependency in kapitan:
without this patch, the
kapitan compile --fetchleads to$ kapitan compile --fetch Dependency https://sourceforge.net/projects/freeplane/files/freeplane%20stable/freeplane_bin-1.10.6.zip/download: fetching now Dependency https://sourceforge.net/projects/freeplane/files/freeplane%20stable/freeplane_bin-1.10.6.zip/download: successfully fetched Dependency https://sourceforge.net/projects/freeplane/files/freeplane%20stable/freeplane_bin-1.10.6.zip/download: Content-Type application/octet-stream is not supported for unpack. Ignoring save ...with patch: