Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix cli alias handling (#776, #737) #837

Merged
merged 1 commit into from
May 16, 2022
Merged

fix cli alias handling (#776, #737) #837

merged 1 commit into from
May 16, 2022

Conversation

dhorbach
Copy link
Contributor

@dhorbach dhorbach commented May 8, 2022

Fixes issue #776, #737

Proposed Changes

  • Caching of args by key should use full command name and not alias
  • Inventory alias is duplicated with init alias - changed "i" to "inv"

@dhorbach
Copy link
Contributor Author

@ramaro could you please review this PR?

@ramaro
Copy link
Member

ramaro commented May 16, 2022

@dhorbach apologies, missed this! Having a look.

@ramaro ramaro merged commit 942deae into kapicorp:master May 16, 2022
@ramaro
Copy link
Member

ramaro commented May 16, 2022

@dhorbach this is great, thank you! Had to review the associated issues and think about it once again, but this makes sense 😃

This was referenced May 16, 2022
Closed
Closed
@dhorbach dhorbach mentioned this pull request May 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramaro ramaro ramaro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhorbach @ramaro