Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow helm binding to be compiled with go 1.16 #702

Merged
merged 1 commit into from
Mar 4, 2021

Conversation

bhesmans
Copy link
Contributor

@bhesmans bhesmans commented Mar 4, 2021

Signed-off-by: Benjamin Hesmans [email protected]

Fixes issue # ??

Did not find any open issue. I tried the build scripts for the binding with go 1.16 and it was not happy

something like

/opt/venv/lib/python3.8/site-packages/kapitan/dependency_manager/helm
go: invalid module path ".": is a local import path

Proposed Changes

  • add a module name to make it build with go 1.16

@ademariag ademariag requested review from ramaro and ademariag March 4, 2021 15:19
@ademariag
Copy link
Contributor

Thank you @bhesmans , we are evaluating #701 which most likely will remove the need for this PR, but it is still worth applying it until we make our mind up for #701

@ademariag ademariag merged commit f0480d0 into kapicorp:master Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants