-
-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update all Dockerfiles to use multi-stage builds #370
Conversation
@taharah This is a very minor thing, but could you update the message on
we output something like
Just so that we or other developers don't get confused? Sorry I didn't do this in the previous PR. |
Signed-off-by: Trevor Wood <[email protected]>
dce2e9b
to
690fa68
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do another pass here and try to simplify these Docker images so maintenance is easier. :)
The initial PR looks good. 👍
Signed-off-by: Trevor Wood <[email protected]>
All looks good now, thank you for fixing the comments. :)
Which I assume is because we also have to |
Signed-off-by: Trevor Wood <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Would be good to get another approval from someone and then merge.
@ramaro or @yoshi-1224 ? :)
Btw, average build time dropped from ~18-19 minutes to 12-13. 👍
Nice work! 👍 |
Signed-off-by: Trevor Wood [email protected]
Fixes issue #367
Proposed Changes