-
-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vault secret backend #310
Vault secret backend #310
Conversation
Signed-off-by: vaibhavk <[email protected]>
@adrianchifor @ramaro review required |
…lt-secret-backend
@vaibhavk any plan on fixing the items we've reviewed? |
@ramaro. Can you please review these new updates? |
Signed-off-by: vaibhavk <[email protected]>
…lt-secret-backend
I tested this PR locally btw and no regression popped up.
Other than that the PR looks good. |
Signed-off-by: vaibhavk <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just 2 nitpicks and I think we're good to merge!
Let's also add some docs (other than the kap) after.
Signed-off-by: vaibhavk <[email protected]>
I'll add the |
That won't work unfortunately because of permissions. Ideally if you update the docs under docs/ on the master branch I can easily update the gh-pages part. :) |
Signed-off-by: vaibhavk <[email protected]>
Signed-off-by: vaibhavk <[email protected]>
Fixes issue #105
Proposed Changes