Fix cli secrets #154
Fix cli secrets #154
Conversation
Example steps to reproduce the error before fix:
```
$ echo -n 'bla' | kapitan secrets --write gpg:secrets/common/test_targets/gcp_project_id -f - -t test_terraform_dummy
Traceback (most recent call last):
File "/Users/rjmco/.pyenv/versions/3.7.0/bin/kapitan", line 11, in <module>
load_entry_point('kapitan==0.18.2', 'console_scripts', 'kapitan')()
File "/Users/rjmco/.pyenv/versions/3.7.0/lib/python3.7/site-packages/kapitan/cli.py", line 279, in main
secret_write(args, ref_controller)
File "/Users/rjmco/.pyenv/versions/3.7.0/lib/python3.7/site-packages/kapitan/cli.py", line 291, in secret_write
file_name = args.file_name
AttributeError: 'Namespace' object has no attribute 'file_name'
```
(cherry picked from commit 76699eb)
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
|
I have read and signed the CLA. I confirm the contribution of my commit to this project as per the CLA. |
Fixes encoding issues when creating gpg secrets using the cli (#150)
Fixes wrong file argument in cli.py
Breaking change: removes --backend in secrets subcommand. New format for secret token in cli is prefix with backend name (now referred as type_name) e.g. gpg:path/to/secret1
Refactor of cli code into smaller functions easier to test.
Test secret cli write and reveal