Do not prune by default #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm afraid of hidden consequences this could have, I'd like this to be tested for longer. |
|
lgtm but agree with Ale. We should probably compile with this new version and apply everywhere while watching for things changing. we should also test creating new targets from scratch. This is a big breaking change so we should also bump version to 0.17.0 |
gburiola
approved these changes
Jun 8, 2018
|
Will merge next week if testing goes ok |
gruzewski
reviewed
Jun 8, 2018
| @@ -64,7 +64,7 @@ def main(): | |||
| help='set search path, default is "."') | |||
| compile_parser.add_argument('--verbose', '-v', help='set verbose mode', | |||
| action='store_true', default=False) | |||
| compile_parser.add_argument('--no-prune', help='do not prune jsonnet output', | |||
There was a problem hiding this comment.
Maybe we could keep it for a while and add a warning that it will be removed in the next version?
Updated rsa key format to PKCS#8 Updated README.md Merge pull request #120 from deepmind/rsa-function-update Updated RSA key format to PKCS#8 Updated CHANGELOG.md Version incremenet 0.16.11 Fixed typo in make_release.sh Merge branch 'master' into disable-prune-by-default Add pretty_printer option to searchvar Merge pull request #121 from deepmind/searchvar_pretty_printer Add pretty_printer option to searchvar Merge branch 'master' into disable-prune-by-default Removed minikube-es-2 from examples Updated demo gif Updated example libjsonnet Updated requests to 2.19.1 Merge pull request #124 from deepmind/deps Updated requests to 2.19.1 Removing monitoring from example libs for now Merge pull request #123 from deepmind/examples-update Examples update Merge branch 'master' into disable-prune-by-default
adrianchifor
force-pushed
the
disable-prune-by-default
branch
from
97c7a7b to
84b9203
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pruning breaks
NetworkPolicyobjects, for example in the default-deny case wherepodSelectorandingresshave to be defined:Default behaviour for no prune is more predictable and clear, with the option of adding
--pruneto compile if you want cleaner output.