Replace abandoned cchardet library #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cchardet is abandonware PyYoshi/cChardet#77 There is a new active fork https://github.com/faust-streaming/cChardet that works on python3.11
This was referenced Feb 15, 2023
kapi2289
approved these changes
Feb 16, 2023
|
Why do we need chardet anyway? I think there's a lot of dependencies in setup.py that are no longer used. |
|
Thanks |
bdraco
added a commit
to home-assistant/core
that referenced
this pull request
Feb 16, 2023
19 tasks
thecode
pushed a commit
to home-assistant/core
that referenced
this pull request
Feb 16, 2023
Bump vulcan-api to 2.3.0 see kapi2289/vulcan-api#126 see #88038 see home-assistant/docker#260
balloob
pushed a commit
to home-assistant/core
that referenced
this pull request
Feb 16, 2023
* Remove profiler.memory service guppy3 is not python3.11 compat zhuyifei1999/guppy3#41 This service will return if and when guppy3 becomes python3.11 compat * squash * temp remove * temp dump tests * temp dump tests * drop a few more to get a run * drop a few more to get a run * Account for changed python3.11 enum.IntFlag behavior in zha There may be additional changes needed, but I could only see what needed to be updated based on the tests * merge * restore * restore * legacy value * tweak a bit for the python 3.11 timings * block cchardet * conditional * adjust est * test * not yet * tweak * give a little leeway for timing * Fix otbr tests * Increase database test timeout It looks like we need a little more time to run with the addiitonal tests in #87019 * Increase database test timeout It looks like we need a little more time to run with the addiitonal tests in #87019 * Fix aprs tests with python 3.11 * merge fix * hints * Update homeassistant/package_constraints.txt * Update script/gen_requirements_all.py * Constrain uamqp for Python 3.10 only * Bump vulcan-api to 2.3.0 see kapi2289/vulcan-api#126 see #88038 see home-assistant/docker#260 * add ban * Bump python-matter-server to 2.1.1 * revert * Update tests/asyncio_legacy.py --------- Co-authored-by: Erik <[email protected]> Co-authored-by: Franck Nijhof <[email protected]> Co-authored-by: Marcel van der Veldt <[email protected]>
AlePerla
pushed a commit
to AlePerla/homeassistant_core
that referenced
this pull request
Feb 17, 2023
Bump vulcan-api to 2.3.0 see kapi2289/vulcan-api#126 see home-assistant#88038 see home-assistant/docker#260
AlePerla
pushed a commit
to AlePerla/homeassistant_core
that referenced
this pull request
Feb 17, 2023
* Remove profiler.memory service guppy3 is not python3.11 compat zhuyifei1999/guppy3#41 This service will return if and when guppy3 becomes python3.11 compat * squash * temp remove * temp dump tests * temp dump tests * drop a few more to get a run * drop a few more to get a run * Account for changed python3.11 enum.IntFlag behavior in zha There may be additional changes needed, but I could only see what needed to be updated based on the tests * merge * restore * restore * legacy value * tweak a bit for the python 3.11 timings * block cchardet * conditional * adjust est * test * not yet * tweak * give a little leeway for timing * Fix otbr tests * Increase database test timeout It looks like we need a little more time to run with the addiitonal tests in home-assistant#87019 * Increase database test timeout It looks like we need a little more time to run with the addiitonal tests in home-assistant#87019 * Fix aprs tests with python 3.11 * merge fix * hints * Update homeassistant/package_constraints.txt * Update script/gen_requirements_all.py * Constrain uamqp for Python 3.10 only * Bump vulcan-api to 2.3.0 see kapi2289/vulcan-api#126 see home-assistant#88038 see home-assistant/docker#260 * add ban * Bump python-matter-server to 2.1.1 * revert * Update tests/asyncio_legacy.py --------- Co-authored-by: Erik <[email protected]> Co-authored-by: Franck Nijhof <[email protected]> Co-authored-by: Marcel van der Veldt <[email protected]>
I think it can actually be dropped. Its an optimization only |
bdraco
added a commit
to bdraco/vulcan-api
that referenced
this pull request
Feb 19, 2023
This lib is an optimization only Removing it per kapi2289#126 (comment) Also PEP 517 wheel builds are currently failing for the lib faust-streaming/cChardet#22 (comment)
bdraco
added a commit
to bdraco/vulcan-api
that referenced
this pull request
Feb 19, 2023
This lib is an optimization only Removing it per kapi2289#126 (comment) Also PEP 517 wheel builds are currently failing for the lib faust-streaming/cChardet#22 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cchardet is abandoned https://docs.aiohttp.org/en/stable/#library-installation PyYoshi/cChardet#77
There is a new active fork https://github.com/faust-streaming/cChardet that works on python3.11